Add pending count to HTML title on pending comments page

[peterwilsoncc]

On the comments page in the dashboard, add the pending comments count to the HTML title similar to Gmail's new mail count, the Twitter notifications page amongst others.

The count would update as new comments come in should an admin have the page open.

[rachelbaker]

@peterwilsoncc This would be a nice small change that would delight moderators for site that receive frequent comments. Would you be able to take a stab at a patch to help move this ticket along?

[peterwilsoncc]

Replying to rachelbaker:

@peterwilsoncc Would you be able to take a stab at a patch to help move this ticket along?

Sure, will do.

[Kau-Boy]

I wrote a little patch that will add the number to the title. It will only do it in HTML, not yet in JS (working on it).

This patch was provided by the #wcnkpg Contributor Day.

[wonderboymusic]

33414.2.diff​ adds the JS to dynamically update the title with proper l10n

[wonderboymusic]

In 33806:

get_comment_count() currently increments awaiting_moderation when comments are in the trash. This occurs because case 0: will match any value passed to switch that is a string that isn't specified in the list of cases. This is terrifying.

• Cases for 0 and 1 should be '1' and '0'
• Add unit tests for get_comment_count(). Currently, there are none.

See #33414.

[afercia]

@wonderboymusic thanks very much for this :) see ticket:19903#comment:10. Also, I'd suggest to have a look at #32362 for 4.4 :)

[Kau-Boy]

Wow @wonderboymusic that looks like a pretty good solution. I haven't been able to finish my JS patch yesterday, but your look better anyways :)

[wonderboymusic]

33414.4.diff​ updates the patch to use wp_count_comments(). It returns comments awaiting moderation on a property called moderated? Why is this code so weird?

[wonderboymusic]

In 33821:

Comments: dynamically update the document title text of the Comments List Table page when dynamically updating the number of comments awaiting moderation.

Fixes #33414.

[wonderboymusic]

In 33982:

After [33821], when dynamically updating the document title text of the Comments List Table page, operate only on the fragment that contains the comment count. This prevents us from including other numbers that may be present in the other title parts (site title, etc).

See #33414.

[ocean90]

Cool feature, but why is it only available for English? :-)

https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/edit-comments.js?rev=33982&marks=143,162,167#L140

[ocean90]

@wonderboymusic Please take a look at 33414.6.diff​.

[wonderboymusic]

looks good, please commit with vigor

[ocean90]

In 35615:

Comments: Dynamically update the document title text for all languages, not only English.

See [33821].
Fixes #33414.