Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#33354 closed defect (bug) (fixed)

Site URL setting description

Reported by: garyj's profile GaryJ Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: ui, administration Cc:

Description

When the General Settings Site Address is set via a defined constant (likely in wp-config.php), then the field correctly gets disabled.

However, the field description ("Enter the address here if you want your site home page to be different from your WordPress installation directory.") becomes a little less correct, as it instructs a user to enter a value into the field, even though that field is disabled.

Attachments (2)

site-url-setting.png (27.6 KB) - added by GaryJ 9 years ago.
Site URL setting, disabled, with incorrect description
33354.diff (985 bytes) - added by dipesh.kakadiya 9 years ago.
General Settings Site Address is set via a defined constant then the field description shouldn't display

Download all attachments as: .zip

Change History (8)

@GaryJ
9 years ago

Site URL setting, disabled, with incorrect description

#1 @GaryJ
9 years ago

  • Keywords needs-patch added

If the constant is found to be defined, display a different description here to reflect that fact? It might then also give a clue to non-developer users that their site is setup with a constant, and that's why these fields are disabled.

@dipesh.kakadiya
9 years ago

General Settings Site Address is set via a defined constant then the field description shouldn't display

#3 @dipesh.kakadiya
9 years ago

  • Keywords has-patch added; needs-patch removed

#4 @dipesh.kakadiya
9 years ago

@SergeyBiryukov

Added patch to remove 'siteurl' option from options-general.php if siteurl set via a defined constant (likely in wp-config.php)

#5 @swissspidy
9 years ago

  • Milestone changed from Awaiting Review to 4.4

I'd like to get this in. Either by removing the description like in the current patch or by changing the description when the constants are defined.

#6 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 35411:

Settings: Don't display Site Address field description if WP_HOME is defined and the field is disabled.

Props dipesh.kakadiya.
Fixes #33354.

Note: See TracTickets for help on using tickets.