MS Sites List Table: Duplicate span elements are output for row actions

[jeremyfelt]

When row_actions() was introduced in [15571], many (most?) of the existing span elements were removed from the arrays of actions built for list tables. The MS Sites List Table survived the change and has resulted in duplicate output ever since. <span class="edit"><span class="edit"><a href="">Edit</a></span> | </span>.

[jeremyfelt]

One issue here is that the class names would change for sites that had been flagged. Previously, the spam action link and the unspam action link were both wrapped with a <span class="spam".... The unspam link would end up being <span class="spam"><span class="unspam"><a href="">Unspam</a></span></span> and the red color attached to .spam a would be applied. The same change happens with activate/unactivate, archive/unarchive.

We can add a rule to apply the same style to unspam or allow the color to change to blue. The attached screenshots show the visual change when a site is marked as spam.

[jeremyfelt]

Not going to clutter the 4.3 list with this. :) It'd be nice to pick this up alongside #15801.

[SergeyBiryukov]

Replying to jeremyfelt:

We can add a rule to apply the same style to unspam or allow the color to change to blue.

I think the latter is fine, unspamming is not a destructive action.

[jeremyfelt]

In 33848:

Multisite: Remove duplicate span element output from row actions

Fixes #32961.