Opened 10 years ago
Closed 10 years ago
#32446 closed defect (bug) (worksforme)
Bundled Themes: `-moz-hyphens: auto` no longer needed
Reported by: | kraftbj | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
Previous to FF v35, -moz-hyphens: auto
was needed to work around a FF bug that caused long words to overflow. For v35+, it adds an excessive amount of hyphens.
Example: https://cloudup.com/cg0iOtT3n1d (Twenty Thirteen)
What's the word on retracting work-arounds when no longer needed?
Attachments (1)
Change History (5)
#1
@
10 years ago
- Keywords needs-testing added
Found in all of the Twenties. Need some eyes to confirm removing it doesn't create a problem.
#2
@
10 years ago
- Keywords has-patch added
- Milestone changed from Awaiting Review to 4.3
- Summary changed from Multiple Twenties: -moz-hyphens: auto no longer needed to Bundled Themes: `-moz-hyphens: auto` no longer needed
I think removing workarounds is a good thing for housekeeping provided that they don't cause problems in older versions. For modern browsers like Firefox it's nice to support 2 major versions back. Since Firefox is on v38 now it should be safe to remove the support and clean up the stylesheets a bit.
#3
@
10 years ago
Does that not remove hyphenation entirely in FF? Testing with 2010 and 2013, I don't get them at all anymore.
#4
@
10 years ago
- Keywords needs-testing removed
- Milestone 4.3 deleted
- Resolution set to worksforme
- Status changed from new to closed
I think we should leave things as-is for now. @kraftbj I thought you meant at first that the prefix for Gecko browsers wasn't needed any more — but it is still needed per https://developer.mozilla.org/en-US/docs/Web/CSS/hyphens.
Remove all -moz-hyphens:auto;