WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#27267 closed defect (bug) (fixed)

Long strings don't break in revision diff

Reported by: iseulde's profile iseulde Owned by: ocean90's profile ocean90
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.8.1
Component: Revisions Keywords: has-patch
Focuses: ui Cc:

Description

See screenshot. The patch below also adds vertical-align: top; as well so content inside a table cell doesn't centre vertically.

Attachments (3)

Screen Shot 2014-03-04 at 01.14.24.png​ (59.4 KB) - added by iseulde 11 years ago.
27267.patch​ (463 bytes) - added by iseulde 11 years ago.
Screen Shot 2014-03-04 at 02.11.55.png​ (30.2 KB) - added by iseulde 11 years ago.
Firefox

Download all attachments as: .zip

Change History (10)

@iseulde
11 years ago

@iseulde
11 years ago

@iseulde
11 years ago

Firefox

#1 @iseulde
11 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
11 years ago

  • Focuses ui added
  • Milestone changed from Awaiting Review to 3.9

#3 @adamsilverstein
11 years ago

Thanks for finding and fixing!

I tested the patch in firefox, chrome and ie 8 (in browserstack) and the results are good.

This should be ready to commit.

This ticket was mentioned in IRC in #wordpress-dev by adamsilverstein. ​View the logs.
11 years ago

#5 @ocean90
11 years ago

Seems like [24930] got reverted at some time, see #24901.

#6 @iseulde
11 years ago

[26072] reverted it.

#7 @ocean90
11 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 27437:

Revisions: Restore [24929] which was reverted in [26072].

props avryl.
fixes #27267.

Note: See TracTickets for help on using tickets.