WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#26263 closed task (blessed) (fixed)

Rename mp6_color_scheme to wp_color_scheme

Reported by: kovshenin's profile kovshenin Owned by: helen's profile helen
Milestone: 3.8 Priority: low
Severity: normal Version: 3.8
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

wp-admin/includes/misc.php defines and wp-includes/js/svg-painter.js uses a variable called mp6_color_scheme which we should probably rename.

Attachments (3)

26263.diff​ (1.4 KB) - added by kovshenin 11 years ago.
26263.2.diff​ (2.8 KB) - added by kovshenin 11 years ago.
26263.3.diff​ (3.7 KB) - added by nacin 11 years ago.

Download all attachments as: .zip

Change History (10)

@kovshenin
11 years ago

#1 @kovshenin
11 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
11 years ago

We should probably remove other MP6 references as well:

#3 @SergeyBiryukov
11 years ago

In 26406:

Rename mp6_color_scheme JS global to wp_color_scheme.

props kovshenin.
see #26263.

@kovshenin
11 years ago

#4 @kovshenin
11 years ago

26263.2.diff​ removes more references to MP6 in CSS and JS. I think the remaining comment in wp-admin.css does not need renaming. It's okay to leave as is or remove the line completely.

#5 @ocean90
11 years ago

wp-admin/js/theme.js is handled in [26460]. [26471] removes some comments in wp-admin/css/colors-fresh.css.

@nacin
11 years ago

#6 @nacin
11 years ago

  • Keywords commit added
  • Priority changed from normal to low

26263.3.diff​ is good to go, pending final decision on .wp-core-ui-* versus .wp-ui-*.

#7 @helen
11 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 26635:

Remove more references to MP6 and standardize on .wp-ui-* for prefixed generic class names. props nacin, kovshenin, fixes #26263.

Note: See TracTickets for help on using tickets.