Opened 11 years ago
Closed 11 years ago
#25404 closed defect (bug) (fixed)
Twenty Fourteen: Gap beneath header image
Reported by: | taupecat | Owned by: | lancewillett |
---|---|---|---|
Milestone: | 3.8 | Priority: | normal |
Severity: | normal | Version: | 3.8 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
When user adds a header image (see #25400), a gap appears between the image and the masthead. Changing the header image's display type to "block" fixes.
Attachments (3)
Change History (10)
#2
follow-up:
↓ 4
@
11 years ago
- Cc iamtakashi added
- Keywords needs-refresh added
- Milestone changed from Awaiting Review to 3.8
I think we should use the a img
selector in line 84 for that since this is a problem with all linked images. It would also make the selector in line 1509 unnecessary.
iamtakashi, can you confirm this?
#3
@
11 years ago
Changing the a img {}
selector makes sense. I'll change my patch accordingly.
However, I'm not seeing how the selector at 1509 is affected...
.hentry .mejs-controls .mejs-time-rail .mejs-time-total, .hentry .mejs-controls .mejs-horizontal-volume-slider .mejs-horizontal-volume-total { background: #595959; }
#4
in reply to:
↑ 2
;
follow-up:
↓ 5
@
11 years ago
Replying to obenland:
I think we should use the
a img
selector in line 84 for that since this is a problem with all linked images. It would also make the selector in line 1509 unnecessary.
iamtakashi, can you confirm this?
I think you're correct. This will be an issue for all linked image so it makes sense to use the selector, a img
. And we should be able to get rid of vertical-align: middle;
from line 1383 - 1389 (I think this is what you meant).
#5
in reply to:
↑ 4
@
11 years ago
Replying to iamtakashi:
I think you're correct. This will be an issue for all linked image so it makes sense to use the selector,
a img
. And we should be able to get rid ofvertical-align: middle;
from line 1383 - 1389 (I think this is what you meant).
Cool. Right, line 1383. I hadn't svn up'ed in a while ;)
Screenshot of gap appearing between header image and masthead