PHP5-Port: Take out unnecessary compat functions from diverse files

[hakre]

Now that we require PHP 5.2.4, let's take out anything in php other than compat.php that is no longer necessary. If you'd like to tackle this, please say so. Please also verify for certain that the functions you're removing are present in ALL PHP 5.2.4 installs.

Related: #16918, #16917

[hakre]

class-http.php

[nacin]

What is this? You literally copied #16918?

[hakre]

class-http.php - more replacements

[hakre]

Replying to nacin:

What is this? You literally copied #16918?

Mind the slight but important difference svp.

[hakre]

deprecate wp_clone()

[hakre]

reg. wp_clone(): #16813

[hakre]

Follow-Up to: #11176

[hakre]

setcookie() has httponly parameter now

[hakre]

E_RECOVERABLE_ERROR is available since PHP 5.2.0

[hakre]

[17535] - some php version compare in class-http, see 16920.patch​, 16920.2.patch​

-- done per that commit.

[hakre]

Related: #16970

[ryan]

(In [17612]) Remove setcookie() back compat. Props hakre. see#16920

[ryan]

(In [17629]) E_RECOVERABLE_ERROR is always available in PHP 5.2+. Remove back compat code. Props hakre. see #16920

[ryan]

(In [17630]) Use stripos() instead of strpos( strtolower() ). Props hakre. see #16920

[duck_]

Three other instances of E_RECOVERABLE_ERROR checks. Patch attached.

[nacin]

(In [17632]) Remove more E_RECOVERABLE_ERROR checks. props duck_, see #16920.

[ocean90]

I have found two PHP4 compat codes:

• get_gmt_from_date() - wp-includes/formatting.php
• _unzip_file_ziparchive() - wp-admin/includes/file.php (dd32?)

[dd32]

_unzip_file_ziparchive() - wp-admin/includes/file.php (dd32?)

Not a compat function

_unzip_file_ziparchive() & _unzip_file_pclzip() are 2 different methods to extract zip files, The first is used when the PHP Zip extension is loaded (Which is not always the case) the 2nd is used in all other cases as it uses pure-PHP code to do the extraction. They're both "private workers" for unzip_file();

[dd32]

Ignore that.. Turns out there was some PHP4 comapt in there: (thanks ocean90)

- $zopen = $z->open($file, /* ZIPARCHIVE::CHECKCONS */ 4);
+ $zopen = $z->open($file, ZIPARCHIVE::CHECKCONS);

[technosailor]

get rid of php4 compat for get_gmt_from_date()/ with unit test

[technosailor]

Unit test for get_gmt_from_date()

[hakre]

Replying to dd32:

Ignore that.. Turns out there was some PHP4 comapt in there: (thanks ocean90)

- $zopen = $z->open($file, /* ZIPARCHIVE::CHECKCONS */ 4);
+ $zopen = $z->open($file, ZIPARCHIVE::CHECKCONS);

​php ZIPARCHIVE constants are not automatically available, so not using the CONST does make still sense with PHP 5.2+.

---

I think this ticket should be still reopend because of technosailor's findings. Patch looks good to me.

[ryan]

In [17920]:

Remove PHP5 back compat code from get_gmt_from_date. Props technosailor. fixes #16920

[ryan]

Of course that should say PHP4 instead of 5 in the commit message.