WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#15112 closed defect (bug) (fixed)

WP->parse_request() shouldn't look in $GLOBALS

Reported by: scribu's profile scribu Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

I'm talking about this:

​http://core.trac.wordpress.org/browser/trunk/wp-includes/classes.php?annotate=blame&rev=15793#L266

I'm ​told it's a (very old) feature.

I don't think it makes sense to have it anymore, as it's causing ​problems and register_globals is evil anyway.

Attachments (1)

15112.diff​ (922 bytes) - added by scribu 14 years ago.

Download all attachments as: .zip

Change History (5)

@scribu
14 years ago

#1 @scribu
14 years ago

  • Keywords has-patch added

#2 @scribu
14 years ago

(In [15796]) Don't look in in WP->parse_request(). See #15112

#3 @scribu
14 years ago

From IRC:

(07:21:41 PM) rboren: I think those were for back compat for the days before extra_query_vars

(07:22:30 PM) rboren: I think it is rarely used by plugins/themes these days and can cause inscrutable bugs.

(07:22:41 PM) rboren: So, let's try eliminating it.

#4 @scribu
14 years ago

  • Milestone changed from Awaiting Review to 3.1
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.