#14274 closed defect (bug) (worksforme)
++ instead of -- on comment total count after edit
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | Priority: | lowest | |
| Severity: | trivial | Version: | 3.0 |
| Component: | Comments | Keywords: | |
| Focuses: | Cc: |
Description
When moderating a comment that removes it from the screen, the total page count, i.e. 1-20 of 67, goes up (68) instead of down (66).
The issue is updateCount() in edit-comments.dev.js, which sets n to n + n1 before returning n. n - n1 is correct, but I think only for this instance of updateCount(), the rest need +. Still looking though.
Attachments (1)
Change History (9)
#1
@
14 years ago
- Keywords has-patch dev-feedback added; needs-patch removed
- Owner set to frankperez87
- Status changed from new to accepted
- Version set to 3.0
#5
@
14 years ago
- Keywords dev-feedback removed
- Owner changed from frankperez87 to scribu
- Status changed from reopened to accepted
With the new pagination style, this is not a problem anymore.
However, we should clean up updateCount().
#6
@
14 years ago
- Keywords has-patch removed
- Milestone changed from 3.1 to Future Release
Punting for now.
Another idea would be to update the entire .subsubsub list when performing an action on the comment, so that we don't have to take care of all the extra logic.
Note: See
TracTickets for help on using
tickets.
From what i saw when checking the comments, the integer after the word of does not update when deleting using the ajax calls. Adding a simple span class of total-type-count around the %s in a sprintf function on line 307 will solve the ajax updates.