Redundant line in WP_Http

[rmccue]

WP_Http has a redundant line, where it strtolower()s a field name after it has already been strtolower()ed.

Attached patch fixes.

(I didn't think it was worth the ticket, but hey, jjj convinced me ;) )

[rmccue]

One-liner patch

[johnjamesjacoby]

I like it alot. Outstanding jorb.

[rmccue]

Oh wow, forgot this.

[Viper007Bond]

Not to mention it's doing == and not === so the capitalization doesn't matter. :)

[nacin]

Replying to Viper007Bond:

Not to mention it's doing == and not === so the capitalization doesn't matter. :)

var_dump( 'test' == 'Test' );
var_dump( 'test' === 'Test' );
bool(false) bool(false)

Equals versus identical has to do with type. Capitalization changes the value itself.

[rmccue]

Replying to Viper007Bond:

Not to mention it's doing == and not === so the capitalization doesn't matter. :)

IIRC, only !strcasecmp($x, $y) would compare strings case-insensitively.

[Viper007Bond]

I think I've made this mistake before. I keep thinking 'test' == 'Test' but 'test' !== 'Test'. Whoops. :)

[dd32]

(In [15362]) Remove redundant strtolower() in WP_HTTP. Props rmccue. Fixes #14168