summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorMarc Mutz <[email protected]>2025-04-03 17:35:10 +0200
committerMarc Mutz <[email protected]>2025-04-16 17:49:12 +0200
commit54865833c537aedd92c8508767f313255086609a (patch)
treeec2f0ad423bb13b031e1639189bcab2f28925434 /src
parente2035be13d4d834fb179b7228e176ff5d4aa1721 (diff)
QAbstractSlider: remove duplicate update() calls from setOrientation()
The sliderChange() base implementation already calls update(), and the only reason we left the update() call in when we added the missing sliderChange() call to setOrientation() was to play it extra safe in the face of misbehaving overrides. For 6.10, make sure to not penalize correct programs anymore. [ChangeLog][Important Behavior Changes][QtWidgets][QAbstractSlider] setOrientation() now relies on sliderChange() to call update(). This was already the case for setRange(), setSingleStep() and setPageStep(), and setOrientation() was only handled specially because of QTBUG-135597. Task-number: QTBUG-135597 Change-Id: I71ec5caf61bc656c2ef3421b4de696eac8623e8e Reviewed-by: Axel Spoerl <[email protected]>
Diffstat (limited to 'src')
-rw-r--r--src/widgets/widgets/qabstractslider.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/widgets/widgets/qabstractslider.cpp b/src/widgets/widgets/qabstractslider.cpp
index d2569c9934d..53579f06b1e 100644
--- a/src/widgets/widgets/qabstractslider.cpp
+++ b/src/widgets/widgets/qabstractslider.cpp
@@ -273,7 +273,6 @@ void QAbstractSlider::setOrientation(Qt::Orientation orientation)
setAttribute(Qt::WA_WState_OwnSizePolicy, false);
}
sliderChange(SliderOrientationChange);
- update();
updateGeometry();
}