diff options
| author | Mirko Boehm (AWS) <[email protected]> | 2013-03-03 13:28:19 +0100 |
|---|---|---|
| committer | The Qt Project <[email protected]> | 2013-03-22 12:59:01 +0100 |
| commit | 4824c74b34eff1603ece275f6dfa22c89919488f (patch) | |
| tree | 1b631acaced6dc38c230f89ff8aa61174581a33d /src/testlib/qxunittestlogger.cpp | |
| parent | 04770e5824cbde365e935b47bd287a9a81fff6f9 (diff) | |
Fix error in XML and Xunit formatted benchmark output.
The number of iterations was not respected for XML output, unlike for
plain text output. With this fix, benchmarks report the same result
for plain text and XML formatted output.
Compare the change to qplaintextlogger.cpp:274.
Change-Id: Ieb3e5812e18d93c36847bef0417f779efd300f86
Reviewed-by: Oswald Buddenhagen <[email protected]>
Reviewed-by: Daniel Molkentin <[email protected]>
Reviewed-by: Jason McDonald <[email protected]>
Diffstat (limited to 'src/testlib/qxunittestlogger.cpp')
| -rw-r--r-- | src/testlib/qxunittestlogger.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/testlib/qxunittestlogger.cpp b/src/testlib/qxunittestlogger.cpp index bfe9de2158b..0a1a5fb6f99 100644 --- a/src/testlib/qxunittestlogger.cpp +++ b/src/testlib/qxunittestlogger.cpp @@ -232,7 +232,9 @@ void QXunitTestLogger::addBenchmarkResult(const QBenchmarkResult &result) QTest::AI_Metric, QTest::benchmarkMetricName(QBenchmarkTestMethodData::current->result.metric)); benchmarkElement->addAttribute(QTest::AI_Tag, result.context.tag.toUtf8().data()); - benchmarkElement->addAttribute(QTest::AI_Value, QByteArray::number(result.value).constData()); + + const qreal valuePerIteration = qreal(result.value) / qreal(result.iterations); + benchmarkElement->addAttribute(QTest::AI_Value, QByteArray::number(valuePerIteration).constData()); char buf[100]; qsnprintf(buf, sizeof(buf), "%i", result.iterations); |
