diff options
| author | Øystein Heskestad <[email protected]> | 2022-01-05 13:10:17 +0100 |
|---|---|---|
| committer | Øystein Heskestad <[email protected]> | 2022-01-07 14:31:38 +0100 |
| commit | 18671b0491e4806fdff95aac6c16a067890ef030 (patch) | |
| tree | 41fad02e0756f430993aadf377189c14b5f62889 /src/plugins/sqldrivers/db2/qsql_db2.cpp | |
| parent | a5b158ed6dd5e393eab78f4034a93ac1250850e3 (diff) | |
Replace QString::utf16() with data() in memcpy() and QByteArray ctor
QString::utf16() needlessly detaches fromRawData() to ensure a
terminating NUL. Use data() where we don't require said NUL, taking
care not to call the mutable data() overload, which would detach,
too.
Task-number: QTBUG-98763
Change-Id: I7075a8f18ab1f82ebbcf8cfab1643e8ab7f38d51
Reviewed-by: Marc Mutz <[email protected]>
Diffstat (limited to 'src/plugins/sqldrivers/db2/qsql_db2.cpp')
| -rw-r--r-- | src/plugins/sqldrivers/db2/qsql_db2.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/sqldrivers/db2/qsql_db2.cpp b/src/plugins/sqldrivers/db2/qsql_db2.cpp index e819d0ea868..e605ac91a20 100644 --- a/src/plugins/sqldrivers/db2/qsql_db2.cpp +++ b/src/plugins/sqldrivers/db2/qsql_db2.cpp @@ -808,11 +808,11 @@ bool QDB2Result::exec() break; } case QMetaType::QString: { - QString str(values.at(i).toString()); + const QString str(values.at(i).toString()); if (*ind != SQL_NULL_DATA) *ind = str.length() * sizeof(QChar); if (bindValueType(i) & QSql::Out) { - QByteArray ba((char*)str.utf16(), str.capacity() * sizeof(QChar)); + QByteArray ba((char *)str.data(), str.capacity() * sizeof(QChar)); r = SQLBindParameter(d->hStmt, i + 1, qParamType[bindValueType(i) & 3], |