summaryrefslogtreecommitdiffstats
path: root/src/network/access/qformdatabuilder.cpp
diff options
context:
space:
mode:
authorGiuseppe D'Angelo <[email protected]>2024-05-24 14:32:47 +0200
committerGiuseppe D'Angelo <[email protected]>2024-05-31 23:38:28 +0000
commitc4fc3a74b4525ad5d80e558707301a12e4d4cb19 (patch)
tree798050a985ec0164e6160acaea036628ff3f6af1 /src/network/access/qformdatabuilder.cpp
parent12d45d049a21eda149d066a5d10b3f32bbf54745 (diff)
QDateTime::fromStdTimePoint: fix a call to fromMSecsSinceEpoch
The overload taking a Qt::TimeSpec is deprecated; we need to use the one taking a QTimeZone instead. However I can't just use QTimeZone because this is inline code in qdatetime.h, and QTimeZone is only forward declared there. Moving the definition in qtimezone.h is possible (like it's done for zoned_time), but that is a source break (requires a new inclusion from users) and also weird (this function doesn't deal with timezones, why do we need to include qtimezone.h?). Instead, just add another overload of fromStdTimePoint that takes precisely sys_time<milliseconds>. As such, it can be always available even in C++17, and implemented out-of-line. Even if this is a new symbol, the new commit policy allows the backport. I also don't think this qualifies as a new feature; it's a cleanup that we forgot to do (if we had a C++20-enabled configuration in the CI when we also did the fromMSecsSinceEpoch deprecation, we would've caught this). Pick-to: 6.7 6.5 Change-Id: Ica77da291be4bcda2ffc7c164316a2977974c386 Reviewed-by: Edward Welbourne <[email protected]>
Diffstat (limited to 'src/network/access/qformdatabuilder.cpp')
0 files changed, 0 insertions, 0 deletions