diff options
| author | Marc Mutz <[email protected]> | 2019-05-27 16:12:17 +0200 |
|---|---|---|
| committer | Marc Mutz <[email protected]> | 2019-05-27 16:12:34 +0200 |
| commit | 5ef6e1fa546a87c1e35b11c9e8c670f8410f88b3 (patch) | |
| tree | 8c37aaf4a4f8605b83f12e276f6c4318ad040b1e /examples/opengl/threadedqopenglwidget/main.cpp | |
| parent | fbb2ed150585ec3aee936eba21b770a8d2b66a4d (diff) | |
Improve qHash(QFont)
When the families member was added to QFontDef, it was included
in op== and qHash(), however the seed was passed to two qHash()
calls for subobjects. With xor used as the combiner, it could
happen that the seed was xored out (e.g. on empty strings),
leaving a slight opening for prediciable hash values.
Fix by using QtPrivate::QHashCombine, which handles the seed in
such a way as to avoid the issue.
Change-Id: I8a3e4c2f368306446554249763695158df5ac634
Reviewed-by: Allan Sandfeld Jensen <[email protected]>
Diffstat (limited to 'examples/opengl/threadedqopenglwidget/main.cpp')
0 files changed, 0 insertions, 0 deletions