aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/languageclient/languageclientquickfix.cpp
Commit message (Collapse)AuthorAgeFilesLines
* qmlls client: append builtin quickfixes to qmlls quickfixesDavid Schulz2024-11-271-11/+17
| | | | | | Fixes: QTCREATORBUG-31977 Change-Id: I6bb59a1606c87203a1c8f4e0cd410560b4ecc835 Reviewed-by: Eike Ziller <[email protected]>
* Remove GPL-3.0+ from license identifiersKai Köhne2023-01-061-1/+1
| | | | | | | | | | | | | | | Since we also license under GPL-3.0 WITH Qt-GPL-exception-1.0, this applies only to a hypothetical newer version of GPL, that doesn't exist yet. If such a version emerges, we can still decide to relicense... While at it, replace (deprecated) GPL-3.0 with more explicit GPL-3.0-only Change was done by running find . -type f -exec perl -pi -e "s/LicenseRef-Qt-Commercial OR GPL-3.0\+ OR GPL-3.0 WITH Qt-GPL-exception-1.0/LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0/g" {} \; Change-Id: I5097e6ce8d10233993ee30d7e25120e2659eb10b Reviewed-by: Eike Ziller <[email protected]>
* LSP: Support remote LSP file pathsDavid Schulz2022-12-151-2/+3
| | | | | Change-Id: If3cf1b8d675ef091427dbcd703c7d14b384a1b3a Reviewed-by: Christian Kandeler <[email protected]>
* Editor: move ownership of assist interface to processorDavid Schulz2022-11-171-6/+4
| | | | | | | | | | This way the base class can manage the lifetime of the interface object and it doesn't need to be done in each implementation of perform. Change-Id: Ie1ce742e31b688a337533ee6c57d376146e25ace Reviewed-by: <[email protected]> Reviewed-by: Christian Stenger <[email protected]> Reviewed-by: Christian Kandeler <[email protected]>
* Editor: unify assist processor handlingDavid Schulz2022-11-141-6/+1
| | | | | | | | | | | Define the run type of the processor by its implementation instead of a enum value of the provider. The execution of a processor inside the assist now follows a unified procedure. Change-Id: Ibe9fab324c6072e77702c2663946d7a9f562a085 Reviewed-by: <[email protected]> Reviewed-by: Christian Stenger <[email protected]> Reviewed-by: Christian Kandeler <[email protected]>
* Utils: Remove Utils::optionalEike Ziller2022-09-011-4/+4
| | | | | | | | | | Since we are now requiring macOS 10.14 we can remove our local implementation of optional and use std::optional for macOS too. Change-Id: I2bd018261b68da64f7f031a812045dd7784697e1 Reviewed-by: Qt CI Bot <[email protected]> Reviewed-by: <[email protected]> Reviewed-by: Marco Bubke <[email protected]>
* Use SPDX license identifiersLucie Gérard2022-08-261-24/+2
| | | | | | | | | Replace the current license disclaimer in files by a SPDX-License-Identifier. Task-number: QTBUG-67283 Change-Id: I708fd1f9f2b73d60f57cc3568646929117825813 Reviewed-by: Eike Ziller <[email protected]>
* Utils: Remove variant.hMarco Bubke2022-08-231-4/+4
| | | | | | | | | | Since we are now requiring macOS 10.14 we can remove our local copy of std::variant and use for macOS std::variant too. Change-Id: I589d03b35fc56878b7392ffa7047a439e588fe43 Reviewed-by: Qt CI Bot <[email protected]> Reviewed-by: <[email protected]> Reviewed-by: Eike Ziller <[email protected]>
* Merge remote-tracking branch 'origin/7.0'Eike Ziller2022-05-181-0/+1
|\ | | | | | | | | | | | | Conflicts: src/plugins/qmlprojectmanager/qmlprojectplugin.cpp Change-Id: I14030f58303839e706af892dd12a67566e3bed68
| * LanguageClient: Track quick fix assist processorDavid Schulz2022-05-131-0/+1
| | | | | | | | | | | | | | | | Same as for the completion and function hint processor, these processors need to be tracked so they get cleaned up on client destruction. Change-Id: Ib24eb8c652e7a44d8b79e1edddda9ad659d145a3 Reviewed-by: Christian Kandeler <[email protected]>
* | LanguageClient: Take quickfix range from cursor selectionChristian Kandeler2022-05-161-6/+7
| | | | | | | | | | | | | | | | | | | | We must respect the selection the user made, otherwise code actions might not work correctly. Change-Id: I39142047f90f3d7c85aefbfa960e59d413e4be38 Reviewed-by: Qt CI Bot <[email protected]> Reviewed-by: <[email protected]> Reviewed-by: David Schulz <[email protected]>
* | ClangCodeModel: remove duplicates from clangd quickfix assistDavid Schulz2022-05-131-30/+26
| | | | | | | | | | | | | | | | Do not report quickfixes with a diagnostic since those are already collected by the ClangdQuickFixFactory as builtin quickfixes. Change-Id: I8d29a08b823291f8beaa762c09b7d29a4b9d0384 Reviewed-by: Christian Kandeler <[email protected]>
* | LanguageClient: avoid optional::valueDavid Schulz2022-02-241-4/+3
| | | | | | | | | | | | | | | | | | Potentially throws std::bad_optional_access. Use operator* and operator-> instead. Change-Id: Idefa137da53f3663ea88961f1105b93402ec4777 Reviewed-by: Eike Ziller <[email protected]> Reviewed-by: <[email protected]>
* | ClangCodeModel: Retrieve all kinds of clangd tweaksChristian Kandeler2022-02-041-7/+0
| | | | | | | | | | | | | | | | | | | | Contrary to our expectation, the "quickfix" tweaks are not part of the inline code actions after all. User-observable effect: "Populate switch" becomes available. Amends 8b63dfccc6. Change-Id: I4f7fa25a58bb54dbdb470d7db064b4d804c34d26 Reviewed-by: David Schulz <[email protected]>
* | ClangCodeModel: Make clangd refactoring actions availableChristian Kandeler2022-02-011-19/+13
|/ | | | | | | | | | | | | | Introduce an assist processor that merges our built-in quickfixes with refactoring actions from clangd ("tweaks"). For now, we make it clear which ones are coming from clangd, and we do not filter duplicate functionality. In the future, we might want to disable redundant built-in actions if clangd is enabled for the respective file. Change-Id: I04842132798c8635dfddf8cfc98cc7a6313fac09 Reviewed-by: <[email protected]> Reviewed-by: Qt CI Bot <[email protected]> Reviewed-by: David Schulz <[email protected]>
* Editor: pass AssistInterface to createProcessorDavid Schulz2021-09-161-1/+1
| | | | | | | | | The interface can be used for checking the context of a codeassist request to determine the correct processor that has to be created. Change-Id: I47ddb05c46399566e27bae21711f11a3a4132c3f Reviewed-by: Christian Kandeler <[email protected]>
* LanguageClient: export code action quick fixesDavid Schulz2021-06-301-20/+14
| | | | | Change-Id: I571378580a1f56bc649662c68eb306a081c0c091 Reviewed-by: Christian Kandeler <[email protected]>
* LSP: prevent accessing already deleted clientDavid Schulz2021-06-171-5/+5
| | | | | Change-Id: Ifdafc77282079b8f99378047e89bbbe44599eebb Reviewed-by: Eike Ziller <[email protected]>
* LanguageClient: manually track document versionDavid Schulz2021-06-151-1/+1
| | | | | | | | Using the document revision causes issues for some servers. Task-number: QTCREATORBUG-25766 Change-Id: Ic858e19c6fe39e57c9d3124913887aafee0a3cd0 Reviewed-by: Christian Stenger <[email protected]>
* LanguageClient: support versioned diagnosticsDavid Schulz2021-02-121-1/+1
| | | | | Change-Id: Id182431f371201c7266fe0683e78fe56a8a9735b Reviewed-by: Christian Stenger <[email protected]>
* TextEditor: use Utils::FilePath as file member in AssistInterfaceDavid Schulz2020-09-041-1/+1
| | | | | Change-Id: I3bf9b013b9350411f918efdb9d1a36a2c22bf972 Reviewed-by: Christian Kandeler <[email protected]>
* LSP: Explicify APIDavid Schulz2020-07-151-1/+1
| | | | | Change-Id: Id208a420fd3e1e23d3279c4f1f19bdbed994a8d3 Reviewed-by: Christian Stenger <[email protected]>
* LSP: fix codeassists running checkDavid Schulz2020-05-141-5/+5
| | | | | | | | Since MessageId is always valid (needs to be fixed separately) use an optional to store whether we have a request running. Change-Id: I7a1f136a09d776b33509bc914247d11076abeaa5 Reviewed-by: Christian Stenger <[email protected]>
* CodeAssist: Fix leaking asynchronous processorsDavid Schulz2020-05-121-0/+2
| | | | | | | | | Currently the ownership of the processor is unknown to the codeassist when running an async operation. Move the ownership of the processor to the assist and delete the processor after the proposal was completed. Change-Id: I6a2e023c47cbc876669dba866bee12b481447cb7 Reviewed-by: Christian Stenger <[email protected]>
* CodeAssistant: add cancel to asynchronous processorsDavid Schulz2020-02-201-4/+13
| | | | | | | | Fixes crash when the processor reports a result after the code assistant was destroyed. Change-Id: I8588d3d6acad69f1ec6302e8ba09d642ebbb77f1 Reviewed-by: Christian Stenger <[email protected]>
* LanguageClient: more FileName to FilePath renamingDavid Schulz2019-09-171-1/+1
| | | | | | Change-Id: I803211d462b442b6881a02e870d2cd816675e0d9 Reviewed-by: David Schulz <[email protected]> Reviewed-by: Christian Stenger <[email protected]>
* LanguageClient: reset all assist providersDavid Schulz2019-09-111-1/+3
| | | | | | | | Instead of just unsetting the function assist provider and quick fix assist provider reset it to the previous provider. Change-Id: I46c5c2f14234e3da08480dd103e4634859447d57 Reviewed-by: Christian Stenger <[email protected]>
* Utils: Rename FileName to FilePathhjk2019-05-281-1/+1
| | | | | | | | More in line with QFileInfo terminonlogy which appears to be best-of-breed within Qt. Change-Id: I1d051ff1c8363ebd4ee56376451df45216c4c9ab Reviewed-by: Christian Kandeler <[email protected]>
* LSP: collect and execute quick fixes via shortcutDavid Schulz2019-02-121-0/+166
Fixes: QTCREATORBUG-21802 Change-Id: I611fac1c3fc5b094816441e36492ed57706c98b8 Reviewed-by: Eike Ziller <[email protected]>