| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
Task-number: QTCREATORBUG-33687
Change-Id: I7c85ab761e43b6e0f1b545754477746e6b1b31ca
Reviewed-by: Marcus Tillmanns <[email protected]>
|
| |
|
|
|
|
|
|
|
| |
The actions are now for files and directories.
Amends fe67869f71e5752a807f4c3bd0a51cda77bceaaf
Change-Id: Id8259afc02edbc6785d0465506c9ffe72e001b84
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
|
| |
Remove the old Tasking lib.
Change-Id: Iacb4939cc873e25d6039efae7dd23510a7baa5f9
Reviewed-by: hjk <[email protected]>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
lupdate has issues finding the right translation context if there are
both Tr::tr calls that should be resolved via a `namespace <name> {`
scope, and another `using namespace <other>` with a namespace that has
another Tr class.
Many of the cases of this that we have were editor display names that
were defined in the Core plugin for reasons unknown, and which would
better be defined in the corresponding plugin anyway.
For the other cases do not use Tr::tr from a different plugin, but
instead introduce "msg<Something>" functions that do the Tr call plugin-
internally. That is the "correct" way to do it anyway, since shared
strings should be changeable centrally.
Task-number: QTBUG-140548
Change-Id: Idacf62b400f50789b5e5957b690e16aa1ebe5a56
Reviewed-by: Christian Stenger <[email protected]>
|
| |
|
|
|
| |
Change-Id: I81d7002ce81a44cea7c52e876ddc326753dcffc6
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
|
|
|
|
| |
Drop the synchronous prefix.
Api: VcsBaseClient::synchronousPull() -> pull()
Api: VcsBaseClient::synchronousPush() -> push()
Change-Id: I00c87b71b814516bff144b584938ab4301eeaf7f
Reviewed-by: André Hartmann <[email protected]>
|
| |
|
|
|
|
|
|
|
| |
Fossil expects the source/destination dir to appear before extra
arguments, so reuse the base implementations and pass
the dir as a first extra option.
Change-Id: Ief54513759f669ad7738f7fb6576ec739c9fcadd
Reviewed-by: André Hartmann <[email protected]>
|
| |
|
|
|
|
|
| |
And get rid of 2 other enums.
Change-Id: I662b43815642f84783d8434a9bec948bf96798ea
Reviewed-by: André Hartmann <[email protected]>
|
| |
|
|
|
| |
Change-Id: I561976079625fc0bb398c7ff07a14b3cde22058a
Reviewed-by: André Hartmann <[email protected]>
|
| |
|
|
|
|
| |
Change-Id: I01dc735993c8ce9ac5432c44857af0292914d4d9
Reviewed-by: Orgad Shaneh <[email protected]>
Reviewed-by: André Hartmann <[email protected]>
|
| |
|
|
|
|
|
| |
The cloneTask() is used instead.
Change-Id: I3d732f12c8604fbcc38f1835df75b088085d1577
Reviewed-by: André Hartmann <[email protected]>
|
| |
|
|
|
| |
Change-Id: I06eb974e4ac510a059fbc2a653698deea22f99e2
Reviewed-by: André Hartmann <[email protected]>
|
| |
|
|
|
|
|
|
| |
Replace them with repositoryChanged() and filesChanged().
Remove to / from QVariant conversions and 3 identical handlers.
Change-Id: I7fb8216af3be047f50c599b1472828b59f6e0dff
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
|
| |
And reuse it in createInitialCheckoutCommand().
Change-Id: I9eda0a5e95261b030e41af2e8cf5d8852c3e8a9a
Reviewed-by: André Hartmann <[email protected]>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of the setRepository() calls, that were missing from
some places anyway and did not support overlapping output from
different working directories.
Also make the basic append() private and only expose the
specialized append...() functions.
The working directory is most often a real repo, but sometimes
also the working directory of a VCS command.
Fixes: QTCREATORBUG-31894
Change-Id: I9988c26307c81dcc5713f339e9d493eaca836131
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
| |
Change-Id: Iad11dcc7393386d3ecc243afd7b51cc93eeab426
Reviewed-by: Jarek Kobus <[email protected]>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toString() is almost always the wrong conversion, but unfortunately
too easy to find and often even working at least for local setup.
This here raises the bar as the non-availability of the "obvious"
toString() hopefully helps people to think about the semantics of
the needed conversion and choose the right toXXX() function.
The chosen new name is intentional ugly to reduce the likelihood
that this (still almost always wrong) function is used out of
convenience.
Change-Id: I57f1618dd95ef2629d7d978688d130275e096c0f
Reviewed-by: Eike Ziller <[email protected]>
|
| |
|
|
|
|
|
|
|
| |
Some were using ICore::dialogParent() directly and the 'nullptr' users
were using that implicitly, but quite a few actually effectively changed
now from some local widget to (implicit) ICore::dialogParent().
Change-Id: Ibb2767b1289221dd26757361235ee88df4a1695e
Reviewed-by: Eike Ziller <[email protected]>
|
| |
|
|
|
|
|
|
|
| |
It doesn't have any dependencies to VcsBase, and this way we can utilize
it in VcsManager directly.
Change-Id: I62c6314b363904055127bc11c4f7426948805c3d
Reviewed-by: André Hartmann <[email protected]>
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
|
|
|
|
| |
Most version control implementations use one or one of a set of specific
files to find a toplevel directory for that version control. Share the
code that searches for these.
Change-Id: Ia308262018f79e59de33b862a020b8cb8138f17f
Reviewed-by: Orgad Shaneh <[email protected]>
Reviewed-by: André Hartmann <[email protected]>
|
| |
|
|
|
|
|
|
|
|
| |
Remove VcsBaseClient::findTopLevelForFile. It was only used by a few
IVersionControl subclasses and always only redirected to
VcsBase::findRepositoryForFile in these cases.
Change-Id: I7af0d98b3289566ca82384e51b357654f4990d56
Reviewed-by: André Hartmann <[email protected]>
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
| |
Change-Id: I6de1ddd036b654472b0a8cc020dc1dbf1bc1d270
Reviewed-by: hjk <[email protected]>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since GitClient is a static object, it's being deleted after
the git plugin is unloaded. We can't make it a parent of VcsCommand
instances, as the process reaper may be already gone.
Use ExtensionSystem::shutdownGuard() as a parent for VcsCommand
instances instead.
This commit reverts d5e8f70192494859b36b5539ab063e2cc0fdd896.
Amends d5e8f70192494859b36b5539ab063e2cc0fdd896
Fixes: QTCREATORBUG-31549
Change-Id: I27e6abbfcac2746e8fa4c447010aab43c11444a9
Reviewed-by: Orgad Shaneh <[email protected]>
Reviewed-by: André Hartmann <[email protected]>
|
| |
|
|
|
| |
Change-Id: Ie4ad575eaa4cd1adea1e10a65dc04f1aa945b300
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
* Uppercase first letter or whole name
* Do not translate the name
* Move implementation to declaration to immediately
see all names in Find Usages
Change-Id: I45f9b8bd8cfab46ab72548d22b140169880fe81f
Reviewed-by: Orgad Shaneh <[email protected]>
Reviewed-by: Eike Ziller <[email protected]>
Reviewed-by: Oswald Buddenhagen <[email protected]>
|
| |
|
|
|
|
|
|
|
|
| |
It has some platform specific warts, filepath.h is somewhat
cheaper and less ugly overall.
Partially clean up surroundings
Change-Id: Ida1fd470ec020f69c446109427f92a08e879789f
Reviewed-by: Jarek Kobus <[email protected]>
|
| |
|
|
|
|
|
| |
... and de-pimpl.
Change-Id: I360379350a696b2d465e869b47c6c02fbd4aa996
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
|
| |
Not in sdktool, which still builds with Qt 5.15
Change-Id: I6e6f4331127b821e471e2840e7959cd65e6419e9
Reviewed-by: Eike Ziller <[email protected]>
|
| |
|
|
|
|
| |
Change-Id: Id154881b4f5d8c488e5c1f5e0f843d36bf838759
Reviewed-by: Orgad Shaneh <[email protected]>
Reviewed-by: <[email protected]>
|
| |
|
|
|
|
|
|
|
|
| |
That makes it easy with Lua plugins, and is useful on the C++ side as
well.
Change-Id: I660956bed47e4c1e27a001ad8999d6701cda86ee
Reviewed-by: Marcus Tillmanns <[email protected]>
Reviewed-by: Leena Miettinen <[email protected]>
Reviewed-by: <[email protected]>
|
| |
|
|
|
|
|
|
|
| |
The running VcsCommand may leak on shutdown. Make them always
a child of a guard object.
Change-Id: Ie2d07d15cd13f1c08636bb1e9c5face09c6a782d
Reviewed-by: <[email protected]>
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Both VcsBaseClient::vcsBinary() and VcsBaseClient::processEnvironment()
get an additional parameter "FilePath target" to allow selecting binaries
and environment based on where the repository is located.
This allows to select e.g. a git binary on a remote device, and the
environment of the remote device for each VCS operation.
A bunch of file path operations are either fixed or ported to actually use
FilePath correctly.
Change-Id: I6afc645772fde3dff3ec19c13efe538e5888e952
Reviewed-by: hjk <[email protected]>
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
|
|
|
| |
Potentially more stable api long-term. Also simplifies the
user side code a bit.
Change-Id: I6913e27e2a5dc14907e72f252081cdbed34842a3
Reviewed-by: Orgad Shaneh <[email protected]>
Reviewed-by: <[email protected]>
|
| |
|
|
|
|
|
|
| |
... and use it to simplify the translation setup.
Change-Id: Ibd386ede3ecfc351316bed53bc184954adbcaa74
Reviewed-by: Orgad Shaneh <[email protected]>
Reviewed-by: <[email protected]>
|
| |
|
|
|
|
|
|
|
| |
Create the editor parameter structures in-place, and also
include the other two parameters in the struct to simplify
the signature of the c'tor.
Change-Id: Iff7d5ddf3096f4a3ed18e53265ae74806823af32
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
| |
Change-Id: Iaf2e6bdb4f04f0f1314ca7725feb63394a693511
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
|
| |
Not worth a separate translation unit anymore.
Change-Id: I579c81c811cd84d89fd39755dca2fbeffae017de
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
| |
Change-Id: I14c4c51a456f7b3b04b79b63b476f89eb58d3ea0
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
|
|
|
|
|
| |
The classes derived from this had a dual role of implementing the
version control interface (IVersionControl) and as the plugin pimpls.
The name was focusing on the latter, but plugin pimpls are being phased
out in the new 'setupFoo()' world, so only the version control interface
part remains.
Change-Id: I60396f1729c736bc6c9e4fca250a5926e9d60f51
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
| |
Change-Id: I203909d9b2d460012b9347d507ac7a701700c48a
Reviewed-by: <[email protected]>
Reviewed-by: Eike Ziller <[email protected]>
|
| |
|
|
|
|
|
|
| |
It became the defacto-type for action when ActionBuilder started
creating them as default.
Change-Id: I1008d60b78ea83919ce1c80a7ef828527fe9902c
Reviewed-by: Eike Ziller <[email protected]>
|
| |
|
|
|
|
|
| |
And split out the tests into a separate class.
Change-Id: I908c4cec5d6a69850867cf2e51c050c8dd356a26
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
|
|
| |
By three liens, the connect in the pluginprivate ctor
will create it.
Change-Id: I23c80884f293fae434de573b8684bde2c56bd45e
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
|
|
| |
Remove some unused headers.
Change-Id: Ied6c6994604d567503b00bfb9e822e8e3784cca6
Reviewed-by: Qt CI Bot <[email protected]>
Reviewed-by: Alessandro Portale <[email protected]>
|
| |\
| |
| |
| | |
Change-Id: Ibe5040142ca38fed77ffed163212baf22592e392
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We didn't mean to execute empty dialog, but RevertDialog.
Add RevertDialog::revision() helper.
Amends 521a23df6e63fd0ba394f728ddc0a4bb271e926f
Change-Id: I4c27baa0d5b2a9360048fd90e4feb1759c6363df
Reviewed-by: Alessandro Portale <[email protected]>
|
| |/
|
|
|
|
|
| |
Last change in that area for this year.
Change-Id: Ibae9f1869cb20faf85c0c1669b84751ad022b8fd
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
|
| |
It works, but we otherwise consistently use "Alt"
Change-Id: I539a481aae1fb3d7da0a05d732122f3b81abfccb
Reviewed-by: Orgad Shaneh <[email protected]>
|
| |
|
|
|
|
| |
Change-Id: Ic86d6b6a4aae7b301557eaa4296beb9a31399e03
Reviewed-by: Leena Miettinen <[email protected]>
Reviewed-by: Qt CI Bot <[email protected]>
|
| |
|
|
|
|
| |
Change-Id: Ie7c995585aafe03428dc5e93b2904b189f0319c0
Reviewed-by: Orgad Shaneh <[email protected]>
Reviewed-by: <[email protected]>
|