VCS: Print error when diff or log fail

Change-Id: I915e42033f01b83a3ad32339dcaef3d4ed2572f6
Reviewed-by: Orgad Shaneh <[email protected]>
Reviewed-by: Marcus Tillmanns <[email protected]>

1 files changed, 7 insertions, 2 deletions

diff --git a/src/plugins/git/gitclient.cpp b/src/plugins/git/gitclient.cpp
index d3bd748480e..1054da6a612 100644
--- a/src/plugins/git/gitclient.cpp
+++ b/src/plugins/git/gitclient.cpp
@@ -251,12 +251,17 @@ GitDiffEditorController::GitDiffEditorController(IDocument *document,
         VcsOutputWindow::appendCommand(process.workingDirectory(), process.commandLine());
     };
     const auto onDiffDone = [diffInputStorage](const Process &process) {
-        *diffInputStorage = process.cleanedStdOut();
+        if (process.result() == ProcessResult::FinishedWithSuccess) {
+            *diffInputStorage = process.cleanedStdOut();
+        } else {
+            VcsOutputWindow::instance()->appendError(process.workingDirectory(),
+                                                     process.cleanedStdErr());
+        }
     };
 
     const Group root {
         diffInputStorage,
-        ProcessTask(onDiffSetup, onDiffDone, CallDone::OnSuccess),
+        ProcessTask(onDiffSetup, onDiffDone, CallDone::Always),
         postProcessTask(diffInputStorage)
     };
     setReloadRecipe(root);