ProjectExplorer: Add convenience accessors to some classes

Namely, Kit, BuildConfiguration, BuildSystem and RunConfiguration get
functions to retrieve the active instance for a given project as well as
the one for the current and active projects, respectively.
This saves a ton of annoying null pointer checks.
Some of these functions replace existing ones with the same purpose that
were scattered around the code base.

Change-Id: I18247061229bbeb8b8ad1e15a2bd7a6626438bc0
Reviewed-by: hjk <[email protected]>

1 files changed, 3 insertions, 3 deletions

diff --git a/src/plugins/cppcheck/cppcheckplugin.cpp b/src/plugins/cppcheck/cppcheckplugin.cpp
index 87a7380b796..53f962535aa 100644
--- a/src/plugins/cppcheck/cppcheckplugin.cpp
+++ b/src/plugins/cppcheck/cppcheckplugin.cpp
@@ -160,10 +160,10 @@ void CppcheckPluginPrivate::startManualRun()
 void CppcheckPluginPrivate::updateManualRunAction()
 {
     const Project *project = ProjectManager::startupProject();
-    const Target *target = ProjectManager::startupTarget();
+    const Kit *kit = activeKitForActiveProject();
     const Utils::Id cxx = ProjectExplorer::Constants::CXX_LANGUAGE_ID;
-    const bool canRun = target && project->projectLanguages().contains(cxx)
-                  && ToolchainKitAspect::cxxToolchain(target->kit());
+    const bool canRun = kit && project->projectLanguages().contains(cxx)
+                  && ToolchainKitAspect::cxxToolchain(kit);
     manualRunAction->setEnabled(canRun);
 }