Skip to content

BL mode: Prevent jump address conflicts #6885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2018

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented May 11, 2018

Description

The Intel hex file format contains enough information to load a program
into memory and begin it's execution. This includes a jump address,
which is generally set to main, that is generated by most compilers. When
merging two Intel hex files, there is no way to know a priori which one
is the true jump address. Therefore, IntelHex (the python package) has
opted to raise an exception: Starting addresses are different. This can
happen when jump address is set in a boot loader and an application; when
both are built as Intel hex. This patch removes jump addresses before
merging the boot loader with the application.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@theotherjimmy
Copy link
Contributor Author

That is possibly the longest explanation I have had for adding one line of code.

@dlfryar-zz
Copy link
Contributor

+1 verified with latest code in mbed-os/master, mbed-bootloader/v3.3.0, and mbed-cloud-client-example/1.3.1.1 on the Nordic NRF52840_DK

@0xc0170
Copy link
Contributor

0xc0170 commented May 14, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 14, 2018

Build : SUCCESS

Build number : 2000
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6885/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 14, 2018

@mbed-ci
Copy link

mbed-ci commented May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants