Scribd
Upload
7 views

Code Review Checklist

The document is a code review checklist that includes various sections for assessing code quality, error handling, resource management, and performance. It outlines specific criteria that must be met, such as proper documentation, error handling, and adherence to coding conventions. The checklist is designed to ensure that code is reliable and meets project standards before release.

Uploaded by

Sachin Jung Karki
Copyright
© © All Rights Reserved
We take content rights seriously. If you suspect this is your content, claim it here.
Available Formats
Download as PDF, TXT or read online on Scribd
7 views

Code Review Checklist

The document is a code review checklist that includes various sections for assessing code quality, error handling, resource management, and performance. It outlines specific criteria that must be met, such as proper documentation, error handling, and adherence to coding conventions. The checklist is designed to ensure that code is reliable and meets project standards before release.

Uploaded by

Sachin Jung Karki
Copyright
© © All Rights Reserved
We take content rights seriously. If you suspect this is your content, claim it here.
Available Formats
Download as PDF, TXT or read online on Scribd
You are on page 1/ 3

Template Version: 01

Effective Date:

Code review checklist

Project Name
Project Manager Name
Software Development/Delivery Manager
(SDM) Name
Reviewed By
Developer Name
Date of Review
Code meant for which version
Reference Id of Release note
Module Name
Purpose of change in short

General Observations
Does the code build correctly? Yes
Does the code execute as expected? Yes
Do you understand the code you are reviewing? Yes
Write the specific purpose.
Has the developer unit tested the code? Yes
Comments and Coding
Conventions
Does the code respect the project coding Yes
conventions?
Does the source file start with an appropriate Yes
header and comments?
Are variable declarations properly commented? Yes
Are units of numeric data if any, clearly stated? Yes
Are all functions, methods and classes Yes
documented?
Are complex algorithms and code optimizations Yes
adequately commented?
Does code that has been commented out have an Yes
explanation?
Are comments used to identify missing NA
functionality or unresolved issues in the code?
Error Handling
Are errors properly handled each time a function Yes
returns?
Are resources and memory released in all error Yes
paths?
Are all thrown exceptions handled properly? Yes
Is the function caller notified when an error is Yes
detected?
Has error-handling code been tested? Yes
Have Transaction Rollbacks been done to NA

Confidential Page: 1 of 3
Date: 04-Sep-2019
Template Version: 01
Effective Date:

appropriate level?
Resource Leaks
Is allocated memory (non-garbage collected) Yes
freed?
Are all objects (Database connections, Sockets, Yes
Files, etc.) freed even when an error occurs?
Is the same object released more than once? No
Control Structures
Are loop ending conditions accurate? Yes
Is the code free of unintended infinite loops? Yes
Performance
Are whole objects duplicated when only references No
are needed?
Does the code have an impact on size, speed, or Yes
memory use?
In SQL Queries –
Do WHERE Clauses use the ‘LIKE%’ Clause?
Do WHERE Clauses use the UPPER function? No
Is SELECT * used anywhere in the code? No

No
Functions
Are function parameters explicitly verified in the No
code?
Are arrays explicitly checked for out-of-bound NA
indexes?
Are variables initialized before they are used? NA
Bug Fixes
Does a fix made to a function change the behavior NA
of caller functions?
Does the bug fix correct all the occurrences of the NA
bug?
TFS Connectivity
Is the developer properly connected with TFS? If Yes
not please specify reason. If connected what is the
Userid used?
Database Related Review
Have the performance tuning steps been done for NA
the query (if any) written for this code change?
Release Review
Have you ensured that the DLL(s) generated are in NA
RELEASE mode

Additional Check Points


If no, then has any new function added in this No
project?
If some logic is changed, how the old data will NA
behave?
If some table is changed / added in the schema? N

Confidential Page: 2 of 3
Date: 04-Sep-2019
Template Version: 01
Effective Date:

Any signature of the existing procedure is changed NA


or not?
Will the transaction data is changed for this CR, If NA
yes, what is the retrospective effect?

Dev TFS will be uploaded first, lastly in UAT Y


TFS?(Y/N)
Specify UATTFS files for this change

Further Observation and Findings:

Follow-up Review History

Follow-up Review Date Reviewer


No.

Sr. Other Functional/technical Observations Status Closure


No. Date

Confidential Page: 3 of 3
Date: 04-Sep-2019

You might also like