Kotlin Cleanup
Kotlin Cleanup
@KotlinCleanup("use assertThrows")
@KotlinCleanup("Enable JUnit 5 in androidTest and use JUnit5Asserter to match the
standard tests")
@KotlinCleanup("maybe delete Shared object and make inner functions as top level")
@KotlinCleanup("set activityName")
@KotlinCleanup("Maybe rename this? This only disables the animation conditionally")
@KotlinCleanup("toast -> snackbar")
@KotlinCleanup("lateinit wherever possible")
@KotlinCleanup("Use Kotlin's Regex methods")
@KotlinCleanup("_templateChanges -> use templateChanges")
@KotlinCleanup("replace _name with `field`")
@KotlinCleanup("remove setTypeface")
@KotlinCleanup("replace setEnableAnimation with var")
@KotlinCleanup("convert to parcelable")
@KotlinCleanup("Simplify")
@KotlinCleanup("add extension method to iterate clip items")
@KotlinCleanup("see about lateinit")
@KotlinCleanup("IDE lint")
@KotlinCleanup("scope function or lateinit db"
@KotlinCleanup("change to enum")
@KotlinCleanup("IDE-lint")
@KotlinCleanup("Go through the class and select elements to fix")
@KotlinCleanup("see if we can lateinit")
@KotlinCleanup("this ideally should be Int, Int?")
@KotlinCleanup("fix suppress")
@KotlinCleanup("convert KeyUtils to extension functions")
@KotlinCleanup("return early and simplify if possible")
@KotlinCleanup("fix !! on oldModel/newModel")
@KotlinCleanup("fix the requireNoNulls")
@KotlinCleanup("make name non-null in FieldEditLine")
@KotlinCleanup("fun interface & use SAM on callers")
@KotlinCleanup("see if we can make variables lazy, or properties without the 's'
prefix")
@KotlinCleanup("lateinit")
@KotlinCleanup("rename object")
@KotlinCleanup("convert to sequence")
@KotlinCleanup("Use a factory here")
@KotlinCleanup("make this use enum instead of Int")
@KotlinCleanup("make selected Tags and indeterminateTags non-null")
@KotlinCleanup("replace _audioPath with 'field`")
@KotlinCleanup("lateinit wherever possible")
@KotlinCleanup("transform into a property")
@KotlinCleanup("convert properties to single-line overrides")
@KotlinCleanup("speed - no need for arrayOfNulls")
@KotlinCleanup("based on getCard() method, cardToAnswer does seem to be not null")
@KotlinCleanup("remove the null check if deck is found to be not null in
DeckManager.get(Long)")
@KotlinCleanup("it's strange")
@KotlinCleanup("replace _delegate with 'field`")
@KotlinCleanup("scope function")
@KotlinCleanup("maybe remove this")
@KotlinCleanup("_state -> field = value in setter")
@KotlinCleanup("SPMockBuilder")
@KotlinCleanup("use extension function")
@KotlinCleanup("auto IDE lint")
@KotlinCleanup("remove JavaField accessors and check for annotations on the
property")
@KotlinCleanup("Remove @Throws")
@KotlinCleanup("Use kotlin based Mockito extensions")
@KotlinCleanup("need a disabled lint check for this as it's a common
issue/operation")
@KotlinCleanup("Use SPMockBuilder")
@KotlinCleanup("improve kotlin code where possible")
@KotlinCleanup("This is flaky just before 4AM")
@KotlinCleanup("android Test/DB Test has corruption but wasn't sufficient. Combine
this with that")