Scribd
Upload
19 views

Code Review

The code review checklist summarizes key items to consider when reviewing code for a project module. It includes 25 questions focused on code quality, best practices, and functionality. Questions address concerns like code complexity, duplication, data handling, dependencies, and physical file storage. The reviewer marks Yes, No, or NA by each item to identify any issues needing to be addressed.

Uploaded by

Dharm Pal
Copyright
© © All Rights Reserved
We take content rights seriously. If you suspect this is your content, claim it here.
Available Formats
Download as PDF, TXT or read online on Scribd
19 views

Code Review

The code review checklist summarizes key items to consider when reviewing code for a project module. It includes 25 questions focused on code quality, best practices, and functionality. Questions address concerns like code complexity, duplication, data handling, dependencies, and physical file storage. The reviewer marks Yes, No, or NA by each item to identify any issues needing to be addressed.

Uploaded by

Dharm Pal
Copyright
© © All Rights Reserved
We take content rights seriously. If you suspect this is your content, claim it here.
Available Formats
Download as PDF, TXT or read online on Scribd
You are on page 1/ 2

Code Review Checklist

Project Name

Module Name(s)

Files Reviewed

Reviewer Name

Review Date

Reviewer Column
ID Items to be considered
(Y/N/NA)
Is the method body more than 50 lines of code? If yes needs to be
1 broken down into separate methods.
Is the same method being used in multiple places with duplication
2 of code? Can it be generalized?
Is there clear differentiation between instance variables and static
3 variables?
4 Are the data objects defined as per the data model?
Are the appropriate methods/functions defined for data objects?
5 (Save/Delete/Update/etc.)
Controllers to only refer data objects rather than raw JSON/XML
6 data.
Are there any loops which can be avoided based on inbuilt
7 functions doing the same task?
8 Is the code traceable from method names for dry run?
Is the method making multiple server calls which can be avoided in
9 a single call?
10 Are the variable names self describing the data they hold?
Is there any duplication of variable names at class/module level and
11 method level? This leads to bugs in code and difficult to debug.
Is code making certain assumptions of available data/environment
12 against which code will execute successfully?
Is code dependent on format/frequency of data from other 3rd
party sources? How well the code handles any future data format
13 changes.
14 Is the functionality of methods tightly bound with UI layer?
Is the client layer making direct server calls without API/Business
15 layers?
Is backend/API code performing any functions based on
16 Cookies/Sessions dependencies?
Is the method performing multiple functions internally rather then
specific function only? This makes method complicated and
17 chances of errors increase.
Are the methods accepting too many parameters? If yes need to be
18 changed by using tuples.
Data types of variables defined according to data model data
19 types?
20 Date not to be stored as String/Text.
21 Boolean data is not stored as String/Text/Int.
Images are not saved as Objects in DB. File name with reference
22 path are saved.
Which data type is used for storing float values? Currency, money,
23 double, float?
Is there any need of storing data in Unicode format for multilingual
24 formats?
Is application writing some physical files/directories on servers? Is
25 the storage path correct for storage when moved to production?

You might also like