Scribd
Upload
50 views1 page

Code Review For Mentors

The document provides suggestions for reorganizing code files and improving code quality. It recommends placing custom cell files in a CustomCell folder, removing CoreData code from AppDelegate and creating separate files for CoreData entities and attributes. It also suggests placing network class files in a Library folder, moving parsing and fetching code to model classes instead of the controller, defining integer constants with a 'k' prefix, and avoiding unnecessary spaces between code lines.

Uploaded by

Iron Force
Copyright
© © All Rights Reserved
We take content rights seriously. If you suspect this is your content, claim it here.
Available Formats
Download as PDF, TXT or read online on Scribd
50 views1 page

Code Review For Mentors

The document provides suggestions for reorganizing code files and improving code quality. It recommends placing custom cell files in a CustomCell folder, removing CoreData code from AppDelegate and creating separate files for CoreData entities and attributes. It also suggests placing network class files in a Library folder, moving parsing and fetching code to model classes instead of the controller, defining integer constants with a 'k' prefix, and avoiding unnecessary spaces between code lines.

Uploaded by

Iron Force
Copyright
© © All Rights Reserved
We take content rights seriously. If you suspect this is your content, claim it here.
Available Formats
Download as PDF, TXT or read online on Scribd
You are on page 1/ 1

1.

Put BGTopicHeaderCell, BGPostListCell, BGProfileSettingCell header and


implementation files at correct place, i.e in CustomCell folder.
2. Remove CoreData code from AppDelegate files, we will make separate files for
CoreData (Managed objects, Relationship, Attributes etc.) when we replace SQLite
(FMDB) with CoreData.
3. Network class files need to be placed within Library folder where we put all third
party libraries.
4. Parsing and fetching data is part of Modal in MVC. So considering the
methodology we would have to place code for fetch/parse within modal classes
where currently data is fetched instead of fetchUserFeedBuilderSuggestion.m
which is actually a Controller.
Some suggestions:
Define constants of type integer with having k as prefix e.g
kTotalNumberOfTabs
Avoid unnecessary spaces between code lines as space with carriage return (new
line) as they are considered while compiling the code.

You might also like