Scribd
Upload
27 views

Lab 5 - Code Review Template

The reviewer summarizes their code review of an application created by another student. They list functions missing from tests or incomplete/buggy. They note tests are needed for controller and participant functions, and the participant repository destroy function. Specifications are commented before implementations, showing clear separation. Layers are correctly separated into UI, domain, repository, and controller. Memory is correctly allocated and deallocated with no dangling pointers. No unclear functions were identified. Filterbyname and undo had problems fixed in half an hour.

Uploaded by

Cicio Flaviu
Copyright
© © All Rights Reserved
We take content rights seriously. If you suspect this is your content, claim it here.
Available Formats
Download as ODT, PDF, TXT or read online on Scribd
27 views

Lab 5 - Code Review Template

The reviewer summarizes their code review of an application created by another student. They list functions missing from tests or incomplete/buggy. They note tests are needed for controller and participant functions, and the participant repository destroy function. Specifications are commented before implementations, showing clear separation. Layers are correctly separated into UI, domain, repository, and controller. Memory is correctly allocated and deallocated with no dangling pointers. No unclear functions were identified. Filterbyname and undo had problems fixed in half an hour.

Uploaded by

Cicio Flaviu
Copyright
© © All Rights Reserved
We take content rights seriously. If you suspect this is your content, claim it here.
Available Formats
Download as ODT, PDF, TXT or read online on Scribd
You are on page 1/ 2

Lab 5 Code Review Template

Reviewer Name: Cicio Flaviu


Reviewer Group: IE1 912/2
Initial C application was created by (Name/Group): Burnete Alexandra
Please fill in the following table using appropriate, complete data:
List
of
application -Filter by name
functionalities
that
are -Undo the last operation
missing, are incomplete or
buggy.
List of program functions
(except UI) that are not
covered by tests.

Controller:
-addParticipant
-removeParticipant
-modifyParticipant
-filterbyprice
-filterbyname
Participant:
-get_given_name
-get_family_name
-get_score
-distruge_participant
ParticipantRepo:
-distrugeRepo
-save
-getNrParticipants
VectorDinamic:
-distruge
-resize
-add
-get
-getNrElemente

List of program functions


lacking specification.

Participant:
-createParticipant
-copyParticipant

Is there a clear separation


between each modules
specification
and
its
implementation?

Specifications are commented in each module just before the


implementation,
So I think that there is a clear separation between
specifications and implementations.

Please detail
Is the application correctly
layered?

Repository -> participantrepo


UI -> console
Domain -> participant

Please detail

Controller -> controller


Application correctly layered.

Does
the
application The application correctly allocate and deallocate memory for
handle memory correctly each participant or dinamic vector.
(all memory is deallocated,
no dangling pointers etc.).
Please detail
List those functions that are unclear to you (you
dont understand their role
or how they work usually
a sign of bad design).
List the problems present There was a problem with filterbyname and undo functions
in the reviewed application which was corrected in approximately half an hour.
and indicate the number of
man-hours you require for
fixing them.

You might also like