Scribd
Upload
26 views

Lab 3 - Code Review Template

The code review identifies missing tests for domain functions and several other functions. It finds the application has clear separation of modules and correct layering but notes some memory allocations are not deallocated. The reviewer would spend 2 hours adding the ability to call test functions at any time by removing static variables.

Uploaded by

Paul Popovici
Copyright
© © All Rights Reserved
Available Formats
Download as DOC, PDF, TXT or read online on Scribd
26 views

Lab 3 - Code Review Template

The code review identifies missing tests for domain functions and several other functions. It finds the application has clear separation of modules and correct layering but notes some memory allocations are not deallocated. The reviewer would spend 2 hours adding the ability to call test functions at any time by removing static variables.

Uploaded by

Paul Popovici
Copyright
© © All Rights Reserved
Available Formats
Download as DOC, PDF, TXT or read online on Scribd
You are on page 1/ 2

Lab 3 Code Review Template

Reviewer Name: Ratiu Octavian


Reviewer Group: 914
Initial C application was created by (Name/Group): Popovici Paul 914
Please fill in the following table using appropriate, complete data:
List
of
application None
functionalities
that
are
missing, are incomplete or
buggy.
List of program functions
(except UI) that are not
covered by tests.

Domain functions are not covered by any tests


In other functions there are several missing tests

List of program functions


lacking specification.

None

Is there a clear separation Each module is specified and implemented correctly


between each modules
specification
and
its
implementation?
Please detail
Is the application correctly
layered?

Yes it is: Main -> UI- > Controller -> Validator , Repository

Please detail
Does
the
application Some memory allocations are not deallocated
handle memory correctly
(all memory is deallocated,
no dangling pointers etc.).
Please detail
List those functions that None
are unclear to you (you
dont understand their role
or how they work usually
a sign of bad design).
List the problems present
in the reviewed application
and indicate the number of
man-hours you require for
fixing them.

There are static variables present. I dont consider it a problem


but I would prefer to be able to call the test functions at any
time. It would take about 2h of work to make the appropriate
changes.

You might also like