| Lists: | pgsql-hackers |
|---|
| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Get rid of PgStat_BackendFunctionEntry |
| Date: | 2023-02-13 09:06:27 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi hackers,
Please find attached a patch proposal to $SUBJECT: it would allow to simplify
even more the work done to generate pg_stat_get_xact*() functions with Macros.
This is a follow up for [1] where it has been suggested
to get rid of PgStat_BackendFunctionEntry in a separate patch.
Looking forward to your feedback,
Regards
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-get_rid_PgStat_BackendFunctionEntry.patch | text/plain | 5.3 KB |
| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Get rid of PgStat_BackendFunctionEntry |
| Date: | 2023-03-08 21:38:38 |
| Message-ID: | 20230308213838.GA3599633@nathanxps13 |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, Feb 13, 2023 at 10:06:27AM +0100, Drouvot, Bertrand wrote:
> Please find attached a patch proposal to $SUBJECT: it would allow to simplify
> even more the work done to generate pg_stat_get_xact*() functions with Macros.
>
> This is a follow up for [1] where it has been suggested
> to get rid of PgStat_BackendFunctionEntry in a separate patch.
Looks reasonable to me.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Get rid of PgStat_BackendFunctionEntry |
| Date: | 2023-03-16 05:25:18 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Mar 08, 2023 at 01:38:38PM -0800, Nathan Bossart wrote:
> Looks reasonable to me.
I have been catching up with this thread and the other thread, and
indeed it looks like this is going to help in refactoring
pgstatfuncs.c to have more macros for all these mostly-duplicated
functions. So, I have applied this bit.
--
Michael
| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Get rid of PgStat_BackendFunctionEntry |
| Date: | 2023-03-16 09:25:59 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
On 3/16/23 6:25 AM, Michael Paquier wrote:
> On Wed, Mar 08, 2023 at 01:38:38PM -0800, Nathan Bossart wrote:
>> Looks reasonable to me.
>
> I have been catching up with this thread and the other thread, and
> indeed it looks like this is going to help in refactoring
> pgstatfuncs.c to have more macros for all these mostly-duplicated
> functions. So, I have applied this bit.
Thanks!
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com