fix: Enable pytype on Pub/Sub Lite repo and fix all errors (#214)

* chore: Enable pytype on Pub/Sub Lite repo and fix all errors

* chore: fix GapicConnection typing

* chore: no empty string notimplementederror

Author: dpcollins-google

google/cloud/pubsublite/admin_client.py

@@ -18,7 +18,7 @@
 from google.api_core.client_options import ClientOptions
 from google.api_core.operation import Operation
 from google.auth.credentials import Credentials
-from google.protobuf.field_mask_pb2 import FieldMask
+from google.protobuf.field_mask_pb2 import FieldMask  # pytype: disable=pyi-error
 
 from google.cloud.pubsublite.admin_client_interface import AdminClientInterface
 from google.cloud.pubsublite.internal.constructable_from_service_account import (

google/cloud/pubsublite/admin_client_interface.py

@@ -27,7 +27,7 @@
 )
 from google.cloud.pubsublite.types.paths import ReservationPath
 from google.cloud.pubsublite_v1 import Topic, Subscription, Reservation
-from google.protobuf.field_mask_pb2 import FieldMask
+from google.protobuf.field_mask_pb2 import FieldMask  # pytype: disable=pyi-error
 
 
 class AdminClientInterface(ABC):

google/cloud/pubsublite/cloudpubsub/internal/ack_set_tracker.py

@@ -12,11 +12,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from abc import abstractmethod
+from abc import abstractmethod, ABCMeta
 from typing import AsyncContextManager
 
 
-class AckSetTracker(AsyncContextManager):
+class AckSetTracker(AsyncContextManager, metaclass=ABCMeta):
     """
     An AckSetTracker tracks disjoint acknowledged messages and commits them when a contiguous prefix of tracked offsets
     is aggregated.

google/cloud/pubsublite/cloudpubsub/internal/make_subscriber.py

@@ -88,6 +88,9 @@ def _make_dynamic_assigner(
     credentials: Optional[Credentials],
     base_metadata: Optional[Mapping[str, str]],
 ) -> Assigner:
+    if base_metadata is None:
+        base_metadata = {}
+
     def assignment_connection_factory(
         requests: AsyncIterator[PartitionAssignmentRequest],
     ):

google/cloud/pubsublite/cloudpubsub/internal/single_partition_subscriber.py

@@ -51,7 +51,7 @@ def str(self) -> str:
         return json.dumps({"generation": self.generation, "offset": self.offset})
 
     @staticmethod
-    def parse(payload: str) -> "_AckId":
+    def parse(payload: str) -> "_AckId":  # pytype: disable=invalid-annotation
         loaded = json.loads(payload)
         return _AckId(
             generation=int(loaded["generation"]), offset=int(loaded["offset"]),

google/cloud/pubsublite/cloudpubsub/internal/single_publisher.py

@@ -12,12 +12,12 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from abc import abstractmethod
+from abc import abstractmethod, ABCMeta
 from typing import AsyncContextManager, Mapping, ContextManager
 from concurrent import futures
 
 
-class AsyncSinglePublisher(AsyncContextManager):
+class AsyncSinglePublisher(AsyncContextManager, metaclass=ABCMeta):
     """
     An AsyncPublisher publishes messages similar to Google Pub/Sub, but must be used in an
     async context. Any publish failures are permanent.
@@ -43,9 +43,10 @@ async def publish(
         Raises:
           GoogleApiCallError: On a permanent failure.
         """
+        raise NotImplementedError()
 
 
-class SinglePublisher(ContextManager):
+class SinglePublisher(ContextManager, metaclass=ABCMeta):
     """
     A Publisher publishes messages similar to Google Pub/Sub. Any publish failures are permanent.
 
@@ -70,3 +71,4 @@ def publish(
         Raises:
           GoogleApiCallError: On a permanent failure.
         """
+        raise NotImplementedError()

google/cloud/pubsublite/cloudpubsub/internal/single_subscriber.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from abc import abstractmethod
+from abc import abstractmethod, ABCMeta
 from typing import AsyncContextManager, Callable, Set, Optional
 
 from google.cloud.pubsub_v1.subscriber.message import Message
@@ -24,7 +24,7 @@
 )
 
 
-class AsyncSingleSubscriber(AsyncContextManager):
+class AsyncSingleSubscriber(AsyncContextManager, metaclass=ABCMeta):
     """
     A Cloud Pub/Sub asynchronous subscriber.
 

google/cloud/pubsublite/cloudpubsub/message_transforms.py

@@ -15,7 +15,7 @@
 import datetime
 
 from google.api_core.exceptions import InvalidArgument
-from google.protobuf.timestamp_pb2 import Timestamp
+from google.protobuf.timestamp_pb2 import Timestamp  # pytype: disable=pyi-error
 from google.pubsub_v1 import PubsubMessage
 
 from google.cloud.pubsublite.cloudpubsub import MessageTransformer

google/cloud/pubsublite/cloudpubsub/publisher_client_interface.py

@@ -12,14 +12,14 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from abc import abstractmethod
+from abc import abstractmethod, ABCMeta
 from concurrent.futures import Future
 from typing import ContextManager, Mapping, Union, AsyncContextManager
 
 from google.cloud.pubsublite.types import TopicPath
 
 
-class AsyncPublisherClientInterface(AsyncContextManager):
+class AsyncPublisherClientInterface(AsyncContextManager, metaclass=ABCMeta):
     """
     An AsyncPublisherClientInterface publishes messages similar to Google Pub/Sub, but must be used in an
     async context. Any publish failures are unlikely to succeed if retried.
@@ -50,9 +50,10 @@ async def publish(
         Raises:
           GoogleApiCallError: On a permanent failure.
         """
+        raise NotImplementedError()
 
 
-class PublisherClientInterface(ContextManager):
+class PublisherClientInterface(ContextManager, metaclass=ABCMeta):
     """
     A PublisherClientInterface publishes messages similar to Google Pub/Sub.
     Any publish failures are unlikely to succeed if retried.
@@ -84,3 +85,4 @@ def publish(
         Raises:
           GoogleApiCallError: On a permanent failure.
         """
+        raise NotImplementedError()

google/cloud/pubsublite/cloudpubsub/subscriber_client_interface.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from abc import abstractmethod
+from abc import abstractmethod, ABCMeta
 from typing import (
     ContextManager,
     Union,
@@ -33,7 +33,7 @@
 )
 
 
-class AsyncSubscriberClientInterface(AsyncContextManager):
+class AsyncSubscriberClientInterface(AsyncContextManager, metaclass=ABCMeta):
     """
     An AsyncSubscriberClientInterface reads messages similar to Google Pub/Sub, but must be used in an
     async context.
@@ -64,12 +64,13 @@ async def subscribe(
         Raises:
           GoogleApiCallError: On a permanent failure.
         """
+        raise NotImplementedError()
 
 
 MessageCallback = Callable[[Message], None]
 
 
-class SubscriberClientInterface(ContextManager):
+class SubscriberClientInterface(ContextManager, metaclass=ABCMeta):
     """
     A SubscriberClientInterface reads messages similar to Google Pub/Sub.
     Any subscribe failures are unlikely to succeed if retried.
@@ -103,3 +104,4 @@ def subscribe(
         Raises:
           GoogleApiCallError: On a permanent failure.
         """
+        raise NotImplementedError()