Skip to content

Commit 0386bc4

Browse files
authored
fix: limit data transferred as part of list_documents as we don't require field data (#280)
* fix: limit data transferred as part of list_documents as we don't require field data
1 parent dffc580 commit 0386bc4

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

google/cloud/firestore_v1/base_collection.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,10 @@ def _prep_list_documents(
183183
"collection_id": self.id,
184184
"page_size": page_size,
185185
"show_missing": True,
186+
# list_documents returns an iterator of document references, which do not
187+
# include any fields. To save on data transfer, we can set a field_path mask
188+
# to include no fields
189+
"mask": {"field_paths": None},
186190
}
187191
kwargs = _helpers.make_retry_timeout_kwargs(retry, timeout)
188192

tests/unit/v1/test_async_collection.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,7 @@ async def _next_page(self):
252252
"collection_id": collection.id,
253253
"page_size": page_size,
254254
"show_missing": True,
255+
"mask": {"field_paths": None},
255256
},
256257
metadata=client._rpc_metadata,
257258
**kwargs,

tests/unit/v1/test_collection.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,7 @@ def _next_page(self):
245245
"collection_id": collection.id,
246246
"page_size": page_size,
247247
"show_missing": True,
248+
"mask": {"field_paths": None},
248249
},
249250
metadata=client._rpc_metadata,
250251
**kwargs,

0 commit comments

Comments
 (0)