-
-
Notifications
You must be signed in to change notification settings - Fork 844
Comparing changes
Open a pull request
base repository: serde-rs/serde
base: v1.0.163
head repository: serde-rs/serde
compare: v1.0.164
- 14 commits
- 18 files changed
- 2 contributors
Commits on May 23, 2023
-
Show error details during miri setup in CI
Without this, if it fails, the only information printed is useless: Preparing a sysroot for Miri (target: x86_64-unknown-linux-gnu)... fatal error: failed to build sysroot; run `cargo miri setup` to see the error details
Configuration menu - View commit details
-
Copy full SHA for a0f850f - Browse repository at this point
Copy the full SHA a0f850fView commit details
Commits on May 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7c2c12a - Browse repository at this point
Copy the full SHA 7c2c12aView commit details -
Merge pull request #2464 from serde-rs/combine
Use syn::Error's combine() API instead of Vec<syn::Error>
Configuration menu - View commit details
-
Copy full SHA for 705e58b - Browse repository at this point
Copy the full SHA 705e58bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1aebdc2 - Browse repository at this point
Copy the full SHA 1aebdc2View commit details
Commits on Jun 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e77db40 - Browse repository at this point
Copy the full SHA e77db40View commit details -
Revert "Ui tests with compile_error resolved at call site"
This reverts commit e77db40.
Configuration menu - View commit details
-
Copy full SHA for bbba632 - Browse repository at this point
Copy the full SHA bbba632View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48e5753 - Browse repository at this point
Copy the full SHA 48e5753View commit details -
Resolve semicolon_if_nothing_returned pedantic clippy lint
error: consider adding a `;` to the last statement for consistent formatting --> serde_derive/src/internals/ast.rs:161:13 | 161 | seen_untagged = variant.attrs.untagged() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `seen_untagged = variant.attrs.untagged();` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned = note: `-D clippy::semicolon-if-nothing-returned` implied by `-D clippy::pedantic` error: consider adding a `;` to the last statement for consistent formatting --> serde_derive/src/internals/ast.rs:159:17 | 159 | ... cx.error_spanned_by(&variant.ident, "all variants with the #[serde(untagged)] attribute must be placed at the end of the enum") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `cx.error_spanned_by(&variant.ident, "all variants with the #[serde(untagged)] attribute must be placed at the end of the enum");` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
Configuration menu - View commit details
-
Copy full SHA for 6081497 - Browse repository at this point
Copy the full SHA 6081497View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43b23c7 - Browse repository at this point
Copy the full SHA 43b23c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 361c23a - Browse repository at this point
Copy the full SHA 361c23aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f60324e - Browse repository at this point
Copy the full SHA f60324eView commit details -
Merge pull request #2470 from dtolnay/contentref
Reuse a single ContentRefDeserializer throughout untagged enum deserialization
Configuration menu - View commit details
-
Copy full SHA for b63c65d - Browse repository at this point
Copy the full SHA b63c65dView commit details -
Point out serde(untagged) variants which are out of order
Previously if someone wrote an enum containing: - `A` (untagged) - `B` (tagged) - `C` (tagged) - `D` (untagged) - `E` (tagged) - `F` (untagged) serde_derive would produce errors referring to B and E only, saying you're supposed to put untagged variants at the end. The choice of B and E for this error doesn't make a lot of sense because in order to resolve the issue, the user must either: - move A and D down or: - move B, C, and E up. This commit changes the error to appear on A and D instead.
Configuration menu - View commit details
-
Copy full SHA for a398237 - Browse repository at this point
Copy the full SHA a398237View commit details -
Configuration menu - View commit details
-
Copy full SHA for 107018c - Browse repository at this point
Copy the full SHA 107018cView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.163...v1.0.164