Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serde-rs/serde
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.163
Choose a base ref
...
head repository: serde-rs/serde
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.164
Choose a head ref
  • 14 commits
  • 18 files changed
  • 2 contributors

Commits on May 23, 2023

  1. Show error details during miri setup in CI

    Without this, if it fails, the only information printed is useless:
    
        Preparing a sysroot for Miri (target: x86_64-unknown-linux-gnu)...
        fatal error: failed to build sysroot; run `cargo miri setup` to see the error details
    dtolnay committed May 23, 2023
    Configuration menu
    Copy the full SHA
    a0f850f View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Configuration menu
    Copy the full SHA
    7c2c12a View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2464 from serde-rs/combine

    Use syn::Error's combine() API instead of Vec<syn::Error>
    dtolnay authored May 25, 2023
    Configuration menu
    Copy the full SHA
    705e58b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1aebdc2 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Configuration menu
    Copy the full SHA
    e77db40 View commit details
    Browse the repository at this point in the history
  2. Revert "Ui tests with compile_error resolved at call site"

    This reverts commit e77db40.
    dtolnay committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    bbba632 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    48e5753 View commit details
    Browse the repository at this point in the history
  4. Resolve semicolon_if_nothing_returned pedantic clippy lint

        error: consider adding a `;` to the last statement for consistent formatting
           --> serde_derive/src/internals/ast.rs:161:13
            |
        161 |             seen_untagged = variant.attrs.untagged()
            |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `seen_untagged = variant.attrs.untagged();`
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
            = note: `-D clippy::semicolon-if-nothing-returned` implied by `-D clippy::pedantic`
    
        error: consider adding a `;` to the last statement for consistent formatting
           --> serde_derive/src/internals/ast.rs:159:17
            |
        159 | ...   cx.error_spanned_by(&variant.ident, "all variants with the #[serde(untagged)] attribute must be placed at the end of the enum")
            |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `cx.error_spanned_by(&variant.ident, "all variants with the #[serde(untagged)] attribute must be placed at the end of the enum");`
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
    dtolnay committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    6081497 View commit details
    Browse the repository at this point in the history
  5. Format PR 2403 with rustfmt

    dtolnay committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    43b23c7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    361c23a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f60324e View commit details
    Browse the repository at this point in the history
  8. Merge pull request #2470 from dtolnay/contentref

    Reuse a single ContentRefDeserializer throughout untagged enum deserialization
    dtolnay authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    b63c65d View commit details
    Browse the repository at this point in the history
  9. Point out serde(untagged) variants which are out of order

    Previously if someone wrote an enum containing:
    
    - `A` (untagged)
    - `B` (tagged)
    - `C` (tagged)
    - `D` (untagged)
    - `E` (tagged)
    - `F` (untagged)
    
    serde_derive would produce errors referring to B and E only, saying
    you're supposed to put untagged variants at the end. The choice of B and
    E for this error doesn't make a lot of sense because in order to resolve
    the issue, the user must either:
    
    - move A and D down
    
    or:
    
    - move B, C, and E up.
    
    This commit changes the error to appear on A and D instead.
    dtolnay committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    a398237 View commit details
    Browse the repository at this point in the history
  10. Release 1.0.164

    dtolnay committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    107018c View commit details
    Browse the repository at this point in the history
Loading