PR#5: Move flatpak-libs to anaconda-gui - rpms/anaconda

rpms / anaconda

#5 Move flatpak-libs to anaconda-gui

Closed 5 years ago by jkonecny. Opened 5 years ago by tdawson.

rpms/ tdawson/anaconda change-flatpack into master

Move flatpak-libs to anaconda-gui

Troy Dawson • 5 years ago

f42735e

anaconda.spec

file modified

+1 -1

		`@@ -100,7 +100,6 @@`
		`Requires: python3-systemd`
		`Requires: python3-pydbus`
		`Requires: python3-productmd`
		`- Requires: flatpak-libs`

		`# pwquality only "recommends" the dictionaries it needs to do anything useful,`
		`# which is apparently great for containers but unhelpful for the rest of us`
		`@@ -203,6 +202,7 @@`
		`Requires: yelp`
		`Requires: blivet-gui-runtime >= %{blivetguiver}`
		`Requires: system-logos`
		`+ Requires: flatpak-libs`

		`# Needed to compile the gsettings files`
		`BuildRequires: gsettings-desktop-schemas`

tdawson commented 5 years ago

flatpack-libs should only be needed with a desktop/gui. It also pulls in a few packages not needed elsewhere, like gsettings-desktop-schemas.
The pull request moves the Requires from anaconda-core to anaconda-gui.

jkonecny commented 5 years ago

Hello,

No, I disagree here.

The point is that you can use this solution for every kind of installation. You can even have the Silverblue installer image without a gui. It's not created officially but there is no reason to not create that by a user.
Another thing is that there is a plan to support flatpaks even by the Fedora Workstation and everything else which would like to support the flatpaks in the future. In that case this would only post-pone the problem not solve it.
The third reason is that implementation is not bound to GUI at all. So moving the dependency will be just wrong reflection of the truth.

If you don't like the pulled dependencies then please create a PR to make flatpak-libs only a library. I don't see a reason to have gsettings-desktop-schemas as libs dependency.