Menu
▾
▴
postgres-xc-committers — Announces PG-XC repository commits
You can subscribe to this list here.
| 2010 |
Jan
|
Feb
|
Mar
|
Apr
(4) |
May
(28) |
Jun
(12) |
Jul
(11) |
Aug
(12) |
Sep
(5) |
Oct
(19) |
Nov
(14) |
Dec
(12) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2011 |
Jan
(18) |
Feb
(30) |
Mar
(115) |
Apr
(89) |
May
(50) |
Jun
(44) |
Jul
(22) |
Aug
(13) |
Sep
(11) |
Oct
(30) |
Nov
(28) |
Dec
(39) |
| 2012 |
Jan
(38) |
Feb
(18) |
Mar
(43) |
Apr
(91) |
May
(108) |
Jun
(46) |
Jul
(37) |
Aug
(44) |
Sep
(33) |
Oct
(29) |
Nov
(36) |
Dec
(15) |
| 2013 |
Jan
(35) |
Feb
(611) |
Mar
(5) |
Apr
(55) |
May
(30) |
Jun
(28) |
Jul
(458) |
Aug
(34) |
Sep
(9) |
Oct
(39) |
Nov
(22) |
Dec
(32) |
| 2014 |
Jan
(16) |
Feb
(16) |
Mar
(42) |
Apr
(179) |
May
(7) |
Jun
(6) |
Jul
(9) |
Aug
|
Sep
(4) |
Oct
|
Nov
(3) |
Dec
|
| 2015 |
Jan
|
Feb
|
Mar
|
Apr
(2) |
May
(4) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: Ashutosh B. <ash...@us...> - 2012-10-30 12:45:39
|
Project "Postgres-XC".
The branch, master has been updated
via 8cb32febe56d62b986598cdad0ae66aeffeb1f63 (commit)
from 16992e6b07d28d66c183adf45dd8e1cae2cdf25b (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=8cb32febe56d62b986598cdad0ae66aeffeb1f63
commit 8cb32febe56d62b986598cdad0ae66aeffeb1f63
Author: Ashutosh Bapat <ash...@en...>
Date: Tue Oct 30 19:20:07 2012 +0530
Push LIMIT clause to the datanode if the expressions in those
clauses are shippable and the underlying plan tree allows that.
In case there is only one datanode involved in the execution of the RemoteQuery,
we just push the clause to the datanode and no LIMIT and OFFSET processing is required at
the coordinator. But for distributed execution of RemoteQuery, we need LIMIT and
OFFSET processing at the coordinator.
If OFFSET clause is present, we do not push it, but include it in the LIMIT
clause and apply OFFSET at the coordinator.
M src/backend/optimizer/path/costsize.c
M src/backend/optimizer/plan/pgxcplan.c
M src/backend/optimizer/plan/planner.c
M src/backend/utils/misc/guc.c
M src/include/optimizer/cost.h
M src/include/optimizer/planmain.h
M src/test/regress/expected/rangefuncs.out
M src/test/regress/expected/rangefuncs_1.out
M src/test/regress/expected/xc_FQS.out
M src/test/regress/parallel_schedule
M src/test/regress/serial_schedule
-----------------------------------------------------------------------
Summary of changes:
src/backend/optimizer/path/costsize.c | 1 +
src/backend/optimizer/plan/pgxcplan.c | 170 ++++++++++++++++++++++++++++
src/backend/optimizer/plan/planner.c | 5 +
src/backend/utils/misc/guc.c | 9 ++
src/include/optimizer/cost.h | 1 +
src/include/optimizer/planmain.h | 1 +
src/test/regress/expected/rangefuncs.out | 3 +-
src/test/regress/expected/rangefuncs_1.out | 3 +-
src/test/regress/expected/xc_FQS.out | 24 ++--
src/test/regress/parallel_schedule | 2 +-
src/test/regress/serial_schedule | 1 +
11 files changed, 205 insertions(+), 15 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-30 07:04:43
|
Project "Postgres-XC".
The branch, master has been updated
via 16992e6b07d28d66c183adf45dd8e1cae2cdf25b (commit)
from 6bf96922d2e0b140820d5f8f62d86b90de628e1f (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=16992e6b07d28d66c183adf45dd8e1cae2cdf25b
commit 16992e6b07d28d66c183adf45dd8e1cae2cdf25b
Author: Michael Paquier <mi...@ot...>
Date: Tue Oct 30 16:02:14 2012 +0900
Move GTM configuration APIs in src/gtm/common to new folder src/gtm/config
This is part of the effort to eliminate the duplications in GTM code with things
of PG src/backend. src/gtm/common had a dependency with the binary postgres when
it is built so this dependency with GTM configuration is unnecessary. Even if
GTM should rely on the APIs of guc-file.l for configuration file treatment, for
the time being this permits to split each functionality correctly.
M src/gtm/Makefile
M src/gtm/common/Makefile
R100 src/gtm/common/.gitignore src/gtm/config/.gitignore
A src/gtm/config/Makefile
R099 src/gtm/common/gtm_opt_handler.c src/gtm/config/gtm_opt_handler.c
R100 src/gtm/common/gtm_opt_scanner.l src/gtm/config/gtm_opt_scanner.l
M src/gtm/main/Makefile
M src/gtm/proxy/Makefile
-----------------------------------------------------------------------
Summary of changes:
src/gtm/Makefile | 2 +-
src/gtm/common/Makefile | 13 ++-----------
src/gtm/{common => config}/.gitignore | 0
src/gtm/{common => config}/Makefile | 25 ++++++++++---------------
src/gtm/{common => config}/gtm_opt_handler.c | 2 +-
src/gtm/{common => config}/gtm_opt_scanner.l | 0
src/gtm/main/Makefile | 3 ++-
src/gtm/proxy/Makefile | 10 +++++-----
8 files changed, 21 insertions(+), 34 deletions(-)
rename src/gtm/{common => config}/.gitignore (100%)
copy src/gtm/{common => config}/Makefile (63%)
rename src/gtm/{common => config}/gtm_opt_handler.c (99%)
rename src/gtm/{common => config}/gtm_opt_scanner.l (100%)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-26 00:50:59
|
Project "Postgres-XC".
The branch, master has been updated
via 6bf96922d2e0b140820d5f8f62d86b90de628e1f (commit)
from c1e66cfc5d182e6b8ecdc4893e5cc8ed33c380a2 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=6bf96922d2e0b140820d5f8f62d86b90de628e1f
commit 6bf96922d2e0b140820d5f8f62d86b90de628e1f
Author: Michael Paquier <mi...@ot...>
Date: Fri Oct 26 09:50:23 2012 +0900
Stop NODE GROUP query pushdown to remote nodes
Those are not DDL operations, but cluster operations, so like NODE related
queries they can only be launched on local Coordinators and need to avoid
dependencies with other nodes.
M src/backend/tcop/utility.c
-----------------------------------------------------------------------
Summary of changes:
src/backend/tcop/utility.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-26 00:50:49
|
Project "Postgres-XC".
The branch, REL1_0_STABLE has been updated
via ed3e7121815b943c55e7e8d6ec675883aaa6edd1 (commit)
from e6320171a0c90542b449be9eddbfb9d9690aba85 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=ed3e7121815b943c55e7e8d6ec675883aaa6edd1
commit 6bf96922d2e0b140820d5f8f62d86b90de628e1f
Author: Michael Paquier <mi...@ot...>
Date: Fri Oct 26 09:50:23 2012 +0900
Stop NODE GROUP query pushdown to remote nodes
Those are not DDL operations, but cluster operations, so like NODE related
queries they can only be launched on local Coordinators and need to avoid
dependencies with other nodes.
M src/backend/tcop/utility.c
-----------------------------------------------------------------------
Summary of changes:
src/backend/tcop/utility.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-24 23:25:58
|
Project "Postgres-XC".
The branch, master has been updated
via c1e66cfc5d182e6b8ecdc4893e5cc8ed33c380a2 (commit)
from 2ab3c8b11d93f018c0642f49c76b40ad3874690c (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=c1e66cfc5d182e6b8ecdc4893e5cc8ed33c380a2
commit c1e66cfc5d182e6b8ecdc4893e5cc8ed33c380a2
Author: Michael Paquier <mi...@ot...>
Date: Thu Oct 25 08:24:21 2012 +0900
Remove reference to slave Datanode and add a note about PREFERRED nodes
This is to refer to user that defining a local node as PREFERRED can show nice
performance improvements especially for remote joins on replicated tables that
can be fully shipped to remote nodes.
M doc-xc/src/sgml/ref/create_node.sgmlin
-----------------------------------------------------------------------
Summary of changes:
doc-xc/src/sgml/ref/create_node.sgmlin | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-24 23:25:47
|
Project "Postgres-XC".
The branch, REL1_0_STABLE has been updated
via e6320171a0c90542b449be9eddbfb9d9690aba85 (commit)
from 30966ed0f594e38bd072f1224d517cd20001fffb (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=e6320171a0c90542b449be9eddbfb9d9690aba85
commit c1e66cfc5d182e6b8ecdc4893e5cc8ed33c380a2
Author: Michael Paquier <mi...@ot...>
Date: Thu Oct 25 08:24:21 2012 +0900
Remove reference to slave Datanode and add a note about PREFERRED nodes
This is to refer to user that defining a local node as PREFERRED can show nice
performance improvements especially for remote joins on replicated tables that
can be fully shipped to remote nodes.
M doc-xc/src/sgml/ref/create_node.sgmlin
-----------------------------------------------------------------------
Summary of changes:
doc-xc/src/sgml/ref/create_node.sgmlin | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-23 08:22:25
|
Project "Postgres-XC".
The branch, master has been updated
via 2ab3c8b11d93f018c0642f49c76b40ad3874690c (commit)
via 786d74ba8bf8058a504df6ac6b20023cfe260991 (commit)
from 23220741845f72669e5bd4bb5825d8818fb16223 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=2ab3c8b11d93f018c0642f49c76b40ad3874690c
commit 2ab3c8b11d93f018c0642f49c76b40ad3874690c
Author: Michael Paquier <mi...@ot...>
Date: Tue Oct 23 17:17:26 2012 +0900
Fix memory allocation issues pointed by ElectricFence (libefence)
Some places of XC code were using realloc with 0-size allocation, making
ElectricFence complain about memory usage on Postgres backend. This commit
ensures that the areas ElectricFence were complaining about have a memory
area enough large based on the parameter values of session.
M src/backend/pgxc/pool/execRemote.c
M src/gtm/client/fe-protocol.c
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=786d74ba8bf8058a504df6ac6b20023cfe260991
commit 2ab3c8b11d93f018c0642f49c76b40ad3874690c
Author: Michael Paquier <mi...@ot...>
Date: Tue Oct 23 17:17:26 2012 +0900
Fix memory allocation issues pointed by ElectricFence (libefence)
Some places of XC code were using realloc with 0-size allocation, making
ElectricFence complain about memory usage on Postgres backend. This commit
ensures that the areas ElectricFence were complaining about have a memory
area enough large based on the parameter values of session.
M src/backend/pgxc/pool/execRemote.c
M src/gtm/client/fe-protocol.c
-----------------------------------------------------------------------
Summary of changes:
src/backend/pgxc/pool/execRemote.c | 21 +++++++++++++++------
src/gtm/client/fe-connect.c | 18 +++++++++++++-----
src/gtm/client/fe-protocol.c | 12 +++++++++---
3 files changed, 37 insertions(+), 14 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-23 08:22:17
|
Project "Postgres-XC".
The branch, REL1_0_STABLE has been updated
via 30966ed0f594e38bd072f1224d517cd20001fffb (commit)
via 7523fd484464a00fb4c2df911ef555d0bcb9e1c2 (commit)
from 929bdd373b0e99cc5008f5b553ca82222a905c3c (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=30966ed0f594e38bd072f1224d517cd20001fffb
commit 2ab3c8b11d93f018c0642f49c76b40ad3874690c
Author: Michael Paquier <mi...@ot...>
Date: Tue Oct 23 17:17:26 2012 +0900
Fix memory allocation issues pointed by ElectricFence (libefence)
Some places of XC code were using realloc with 0-size allocation, making
ElectricFence complain about memory usage on Postgres backend. This commit
ensures that the areas ElectricFence were complaining about have a memory
area enough large based on the parameter values of session.
M src/backend/pgxc/pool/execRemote.c
M src/gtm/client/fe-protocol.c
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=7523fd484464a00fb4c2df911ef555d0bcb9e1c2
commit 2ab3c8b11d93f018c0642f49c76b40ad3874690c
Author: Michael Paquier <mi...@ot...>
Date: Tue Oct 23 17:17:26 2012 +0900
Fix memory allocation issues pointed by ElectricFence (libefence)
Some places of XC code were using realloc with 0-size allocation, making
ElectricFence complain about memory usage on Postgres backend. This commit
ensures that the areas ElectricFence were complaining about have a memory
area enough large based on the parameter values of session.
M src/backend/pgxc/pool/execRemote.c
M src/gtm/client/fe-protocol.c
-----------------------------------------------------------------------
Summary of changes:
src/backend/pgxc/pool/execRemote.c | 21 +++++++++++++++------
src/gtm/client/fe-connect.c | 18 +++++++++++++-----
src/gtm/client/fe-protocol.c | 12 +++++++++---
3 files changed, 37 insertions(+), 14 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-22 01:27:44
|
Project "Postgres-XC".
The branch, master has been updated
via 23220741845f72669e5bd4bb5825d8818fb16223 (commit)
from 9ce38d3bf64c17155a0ca283c56987b7ecd9e218 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=23220741845f72669e5bd4bb5825d8818fb16223
commit 23220741845f72669e5bd4bb5825d8818fb16223
Author: Michael Paquier <mi...@ot...>
Date: Mon Oct 22 10:23:40 2012 +0900
Index expressions shippability analysis for distribution columns
This commit strengthens determination analysis of unique index expressions
shippability for value-distributed tables.
For example, in the case of a cluster with 2 Datanodes:
CREATE TABLE aa (a int) DISTRIBUTE BY HASH(a);
CREATE UNIQUE INDEX aap ON (abs(a));
INSERT INTO aa (2); -- To Datanode 1
INSERT INTO aa (-2); -- To Datanode 2
The index uniqueness is not ensured here even if the index expression constains
only the distribution column of parent relation. Such expressions are not
shippable, and as XC does not support yet global constraints such index creation
is simply blocked.
Also, if the table has its data located on a single node, its index uniqueness
can be evaluated safely in all the cases, a condition is added to treat that
case.
M src/backend/optimizer/util/pgxcship.c
M src/test/regress/expected/xc_constraints.out
M src/test/regress/sql/xc_constraints.sql
-----------------------------------------------------------------------
Summary of changes:
src/backend/optimizer/util/pgxcship.c | 56 +++++++++++---------------
src/test/regress/expected/xc_constraints.out | 3 +-
src/test/regress/sql/xc_constraints.sql | 2 +-
3 files changed, 26 insertions(+), 35 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-16 08:40:35
|
Project "Postgres-XC".
The branch, master has been updated
via 9ce38d3bf64c17155a0ca283c56987b7ecd9e218 (commit)
from 945f83fc5d5b2ef1d51438a7dd48dd9532c9d936 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=9ce38d3bf64c17155a0ca283c56987b7ecd9e218
commit 9ce38d3bf64c17155a0ca283c56987b7ecd9e218
Author: Michael Paquier <mi...@ot...>
Date: Tue Oct 16 17:21:57 2012 +0900
GROUP BY clause pushdown optimization with distribution data and aggregates
This patch is a lightly modified version of 66c17a5 reverted by 6c6ba3c once
some errors have been noticed regarding aggregate pushdown, like:
SELECT count(*) FROM tab;
where the query was completely pushed down and returned multiple row results
to client (1 per Datanode).
Patch and subsequent fix from Ashutosh Bapat, I just did some testing.
M src/backend/nodes/copyfuncs.c
M src/backend/nodes/outfuncs.c
M src/backend/optimizer/plan/pgxcplan.c
M src/backend/optimizer/plan/setrefs.c
M src/backend/optimizer/util/pgxcship.c
M src/include/optimizer/pgxcplan.h
M src/include/optimizer/pgxcship.h
M src/test/regress/expected/aggregates.out
M src/test/regress/expected/aggregates_1.out
M src/test/regress/expected/xc_FQS.out
M src/test/regress/expected/xc_groupby.out
M src/test/regress/expected/xc_having.out
M src/test/regress/sql/xc_FQS.sql
M src/test/regress/sql/xc_groupby.sql
M src/test/regress/sql/xc_having.sql
-----------------------------------------------------------------------
Summary of changes:
src/backend/nodes/copyfuncs.c | 1 -
src/backend/nodes/outfuncs.c | 1 -
src/backend/optimizer/plan/pgxcplan.c | 570 +++++++-------
src/backend/optimizer/plan/setrefs.c | 98 +++
src/backend/optimizer/util/pgxcship.c | 26 +-
src/include/optimizer/pgxcplan.h | 1 -
src/include/optimizer/pgxcship.h | 2 +
src/test/regress/expected/aggregates.out | 38 +-
src/test/regress/expected/aggregates_1.out | 36 +-
src/test/regress/expected/xc_FQS.out | 12 +-
src/test/regress/expected/xc_groupby.out | 1154 ++++++++++++----------------
src/test/regress/expected/xc_having.out | 274 +++----
src/test/regress/sql/xc_FQS.sql | 2 +-
src/test/regress/sql/xc_groupby.sql | 275 ++++----
src/test/regress/sql/xc_having.sql | 24 +-
15 files changed, 1227 insertions(+), 1287 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-15 00:39:13
|
Project "Postgres-XC".
The branch, master has been updated
via 945f83fc5d5b2ef1d51438a7dd48dd9532c9d936 (commit)
from d165a5c2458e97cbf943135cf1bb534b8f8af807 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=945f83fc5d5b2ef1d51438a7dd48dd9532c9d936
commit 945f83fc5d5b2ef1d51438a7dd48dd9532c9d936
Author: Michael Paquier <mi...@ot...>
Date: Mon Oct 15 09:14:58 2012 +0900
Fix for COPY query generation with quoted column names
Report and patch by Nikhil Sontakke, completed with esthetic changes.
M src/backend/pgxc/copy/remotecopy.c
M src/test/regress/input/xc_copy.source
M src/test/regress/output/xc_copy.source
-----------------------------------------------------------------------
Summary of changes:
src/backend/pgxc/copy/remotecopy.c | 56 ++++---------------------------
src/test/regress/input/xc_copy.source | 18 ++++++++--
src/test/regress/output/xc_copy.source | 16 +++++++--
3 files changed, 34 insertions(+), 56 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-15 00:39:05
|
Project "Postgres-XC".
The branch, REL1_0_STABLE has been updated
via 929bdd373b0e99cc5008f5b553ca82222a905c3c (commit)
from c9035af181c91d5766c88029b28e48b466ea1b46 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=929bdd373b0e99cc5008f5b553ca82222a905c3c
commit 945f83fc5d5b2ef1d51438a7dd48dd9532c9d936
Author: Michael Paquier <mi...@ot...>
Date: Mon Oct 15 09:14:58 2012 +0900
Fix for COPY query generation with quoted column names
Report and patch by Nikhil Sontakke, completed with esthetic changes.
M src/backend/pgxc/copy/remotecopy.c
M src/test/regress/input/xc_copy.source
M src/test/regress/output/xc_copy.source
-----------------------------------------------------------------------
Summary of changes:
src/backend/commands/copy.c | 59 ++++---------------------------
src/test/regress/input/xc_copy.source | 18 +++++++--
src/test/regress/output/xc_copy.source | 16 ++++++--
3 files changed, 34 insertions(+), 59 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-12 03:04:57
|
Project "Postgres-XC".
The branch, master has been updated
via d165a5c2458e97cbf943135cf1bb534b8f8af807 (commit)
from dfb46fa4df777fd4641a1a1e5aefc5dc6cef43c7 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=d165a5c2458e97cbf943135cf1bb534b8f8af807
commit d165a5c2458e97cbf943135cf1bb534b8f8af807
Author: Michael Paquier <mi...@ot...>
Date: Fri Oct 12 12:00:58 2012 +0900
Refactor and clean-up of relation locator code
Locator is the part in charge of managing, building and referencing
distribution information of tables in catalogs by providing sufficient
functions that backends can refer to.
Some of this code was pretty outdated and a portion of the APIs used
were duplicated, making the code more difficult to apprehend. Locator
information also included the following information:
- OID of relation it refers to
- Attribute number of distribution key if distribution is value-based
- Column name of distribution key
As column name can be retrieved from system cache by using simply OID
and attribute number, the column name is removed, simplifying the code
by that much. So now all the APIs of locator.c and related only use the
attribute number of a relation when referencing the distribution key inside
code. This cleanup also tackles some potential bugs related to hash/modulo
management that might have appeared if other value-based distribution would
have been defined in XC. So code is more extensible now.
M src/backend/catalog/heap.c
M src/backend/commands/tablecmds.c
M src/backend/optimizer/plan/pgxcplan.c
M src/backend/optimizer/util/pgxcship.c
M src/backend/parser/parse_utilcmd.c
M src/backend/pgxc/locator/locator.c
M src/backend/pgxc/locator/redistrib.c
M src/backend/rewrite/rewriteHandler.c
M src/include/pgxc/locator.h
-----------------------------------------------------------------------
Summary of changes:
src/backend/catalog/heap.c | 6 +-
src/backend/commands/tablecmds.c | 14 +-
src/backend/optimizer/plan/pgxcplan.c | 9 +-
src/backend/optimizer/util/pgxcship.c | 2 +-
src/backend/parser/parse_utilcmd.c | 11 +-
src/backend/pgxc/locator/locator.c | 334 +++++++--------------------------
src/backend/pgxc/locator/redistrib.c | 6 +-
src/backend/rewrite/rewriteHandler.c | 2 +-
src/include/pgxc/locator.h | 83 ++++-----
9 files changed, 133 insertions(+), 334 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-12 01:05:49
|
Project "Postgres-XC".
The branch, master has been updated
via dfb46fa4df777fd4641a1a1e5aefc5dc6cef43c7 (commit)
from c41d90b8af6eb100784e3fdaf89375683c092849 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=dfb46fa4df777fd4641a1a1e5aefc5dc6cef43c7
commit dfb46fa4df777fd4641a1a1e5aefc5dc6cef43c7
Author: Michael Paquier <mi...@ot...>
Date: Fri Oct 12 10:03:48 2012 +0900
Ignore automatically generated regression outputs specific to Postgres-XC
This will avoid unfortunate commit of files that should not be in central
repository...
M src/test/regress/expected/.gitignore
-----------------------------------------------------------------------
Summary of changes:
src/test/regress/expected/.gitignore | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-12 01:05:41
|
Project "Postgres-XC".
The branch, REL1_0_STABLE has been updated
via c9035af181c91d5766c88029b28e48b466ea1b46 (commit)
from d0683e5711aa899832b1b1a53a329e7d162dd2b5 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=c9035af181c91d5766c88029b28e48b466ea1b46
commit dfb46fa4df777fd4641a1a1e5aefc5dc6cef43c7
Author: Michael Paquier <mi...@ot...>
Date: Fri Oct 12 10:03:48 2012 +0900
Ignore automatically generated regression outputs specific to Postgres-XC
This will avoid unfortunate commit of files that should not be in central
repository...
M src/test/regress/expected/.gitignore
-----------------------------------------------------------------------
Summary of changes:
src/test/regress/expected/.gitignore | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-12 00:57:25
|
Project "Postgres-XC".
The branch, master has been updated
via c41d90b8af6eb100784e3fdaf89375683c092849 (commit)
from 6c6ba3c4583bd55edf5d3498d57635dec36419e0 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=c41d90b8af6eb100784e3fdaf89375683c092849
commit c41d90b8af6eb100784e3fdaf89375683c092849
Author: Michael Paquier <mi...@ot...>
Date: Fri Oct 12 09:45:27 2012 +0900
Refactor code controlling constraint creation evaluation
The code refactored in this commit is present in XC since the beginning of
the project and was outdated. The former code was put inside the utility
deparser to control UNIQUE, PRIMARY KEY, EXCLUDE and FOREIGN KEY creation.
This was a fundamental mistake as this did not allow control of FOREIGN KEY
creation with generic functions that could also be used to evaluate the
shippability of constraints when issuing a DML on a given relation or when
modifying a relation distribution with ALTER TABLE (online data redistribution
feature).
Now all this control is put directly inside Postgres-XC shippability evaluation
code and can be used in a wider way than the previous implementation. All the
error messages are now made generic and refer to the impossibility to create
constraints whose evaluation cannot be enforced to remote nodes.
Postgres-XC does not support yet global constraints, but once it does, it will
be necessary to remove the error messages referring to constraint evaluation
and to use the APIs implemented in this commit not to control the creation of
constraints but to check the shippability of a Query for a given relation
constraint.
The old code was also deeply lacking evaluation of index expressions, so some
control is added about that. A regression test called xc_constraints check the
shippability of constraints created on tables depending on their distribution.
Documentation is also updated, but might need more completion.
The code in this commit checks if redistribution with ALTER TABLE can be done
according to the given constraints already on it for UNIQUE, EXCLUDE and PRIMARY
KEY. For example, you should not be able to change a replicated table with a
primary key to roundrobin you cannot ensure the uniqueness of a key on such
tables so now this is protected properly. However, such checks are still missing
for FOREIGN KEY and REFERENCES.
M doc-xc/src/sgml/ddl.sgmlin
M src/backend/commands/indexcmds.c
M src/backend/commands/tablecmds.c
M src/backend/optimizer/util/pgxcship.c
M src/backend/parser/parse_utilcmd.c
M src/include/optimizer/pgxcship.h
M src/test/regress/expected/alter_table.out
M src/test/regress/expected/cluster_1.out
M src/test/regress/expected/create_index.out
M src/test/regress/expected/create_table.out
M src/test/regress/expected/enum.out
M src/test/regress/expected/functional_deps_1.out
M src/test/regress/expected/hash_index_1.out
M src/test/regress/expected/namespace_1.out
M src/test/regress/expected/rangetypes.out
M src/test/regress/expected/sanity_check.out
M src/test/regress/expected/triggers_1.out
M src/test/regress/expected/tsearch_2.out
M src/test/regress/expected/typed_table_1.out
M src/test/regress/expected/uuid_1.out
A src/test/regress/expected/xc_constraints.out
M src/test/regress/input/constraints.source
M src/test/regress/output/constraints_1.source
M src/test/regress/parallel_schedule
M src/test/regress/serial_schedule
M src/test/regress/sql/create_index.sql
M src/test/regress/sql/create_table.sql
M src/test/regress/sql/rangetypes.sql
A src/test/regress/sql/xc_constraints.sql
-----------------------------------------------------------------------
Summary of changes:
doc-xc/src/sgml/ddl.sgmlin | 15 +-
src/backend/commands/indexcmds.c | 56 +++--
src/backend/commands/tablecmds.c | 60 +++++
src/backend/optimizer/util/pgxcship.c | 306 +++++++++++++++++++++++
src/backend/parser/parse_utilcmd.c | 217 +----------------
src/include/optimizer/pgxcship.h | 12 +
src/test/regress/expected/alter_table.out | 4 +-
src/test/regress/expected/cluster_1.out | 3 +-
src/test/regress/expected/create_index.out | 21 +-
src/test/regress/expected/create_table.out | 5 +-
src/test/regress/expected/enum.out | 2 +-
src/test/regress/expected/functional_deps_1.out | 4 +-
src/test/regress/expected/hash_index_1.out | 3 +-
src/test/regress/expected/namespace_1.out | 2 +-
src/test/regress/expected/rangetypes.out | 2 +-
src/test/regress/expected/sanity_check.out | 2 +-
src/test/regress/expected/triggers_1.out | 3 +-
src/test/regress/expected/tsearch_2.out | 2 +-
src/test/regress/expected/typed_table_1.out | 2 +-
src/test/regress/expected/uuid_1.out | 2 +-
src/test/regress/expected/xc_constraints.out | 88 +++++++
src/test/regress/input/constraints.source | 2 +-
src/test/regress/output/constraints_1.source | 2 +-
src/test/regress/parallel_schedule | 2 +-
src/test/regress/serial_schedule | 1 +
src/test/regress/sql/create_index.sql | 10 +-
src/test/regress/sql/create_table.sql | 5 +-
src/test/regress/sql/rangetypes.sql | 2 +-
src/test/regress/sql/xc_constraints.sql | 65 +++++
29 files changed, 626 insertions(+), 274 deletions(-)
create mode 100644 src/test/regress/expected/xc_constraints.out
create mode 100644 src/test/regress/sql/xc_constraints.sql
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-12 00:31:23
|
Project "Postgres-XC".
The branch, master has been updated
via 6c6ba3c4583bd55edf5d3498d57635dec36419e0 (commit)
from 66c17a5a348a4ed09859be3c45c64e9a99cc2d49 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=6c6ba3c4583bd55edf5d3498d57635dec36419e0
commit 6c6ba3c4583bd55edf5d3498d57635dec36419e0
Author: Michael Paquier <mi...@ot...>
Date: Fri Oct 12 09:26:50 2012 +0900
Revert "The commit has following changes: GROUP BY optimization patch"
This reverts commit 66c17a5a348a4ed09859be3c45c64e9a99cc2d49.
This patch basically broke HEAD for aggregate pushdown, so
reverting it is the right thing to do to keep a master version
stable.
M src/backend/nodes/copyfuncs.c
M src/backend/nodes/outfuncs.c
M src/backend/optimizer/plan/pgxcplan.c
M src/backend/optimizer/plan/setrefs.c
M src/backend/optimizer/util/pgxcship.c
M src/include/optimizer/pgxcplan.h
M src/include/optimizer/pgxcship.h
M src/test/regress/expected/aggregates.out
M src/test/regress/expected/aggregates_1.out
M src/test/regress/expected/xc_FQS.out
M src/test/regress/expected/xc_groupby.out
M src/test/regress/expected/xc_having.out
M src/test/regress/sql/xc_FQS.sql
M src/test/regress/sql/xc_groupby.sql
M src/test/regress/sql/xc_having.sql
-----------------------------------------------------------------------
Summary of changes:
src/backend/nodes/copyfuncs.c | 1 +
src/backend/nodes/outfuncs.c | 1 +
src/backend/optimizer/plan/pgxcplan.c | 563 +++++++-------
src/backend/optimizer/plan/setrefs.c | 98 ---
src/backend/optimizer/util/pgxcship.c | 26 +-
src/include/optimizer/pgxcplan.h | 1 +
src/include/optimizer/pgxcship.h | 1 -
src/test/regress/expected/aggregates.out | 38 +-
src/test/regress/expected/aggregates_1.out | 36 +-
src/test/regress/expected/xc_FQS.out | 12 +-
src/test/regress/expected/xc_groupby.out | 1154 ++++++++++++++++------------
src/test/regress/expected/xc_having.out | 274 ++++---
src/test/regress/sql/xc_FQS.sql | 2 +-
src/test/regress/sql/xc_groupby.sql | 275 ++++----
src/test/regress/sql/xc_having.sql | 24 +-
15 files changed, 1287 insertions(+), 1219 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Ashutosh B. <ash...@us...> - 2012-10-11 08:52:18
|
Project "Postgres-XC".
The branch, master has been updated
via 66c17a5a348a4ed09859be3c45c64e9a99cc2d49 (commit)
from 7b633f16bf11ade60acef4520c614dc3dd5704b8 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=66c17a5a348a4ed09859be3c45c64e9a99cc2d49
commit 66c17a5a348a4ed09859be3c45c64e9a99cc2d49
Author: Ashutosh Bapat <ash...@en...>
Date: Thu Oct 11 14:18:14 2012 +0530
The commit has following changes.
1. If each group according to GROUP BY clause resides completely on a single
datanode i.e. GROUP BY has distribution column in it for distributed underlying
relation or the underlying relation is a replicated relation, finalise the
aggregates on the datanodes. There is no need for a covering Group or Agg node in
the standard planner.
2. All the optimizations related to GROUP BY and aggregation are now available
even if the query has ORDER BY or DISTINCT clauses in it. (Earlier they were
not.)
Implementation details
---------------------------------
We push aggregates to the datanodes to get transition results for each group and
then apply combination and finalization phase at the coordinator. This is done
by substituting Aggref nodes in RemoteQuery targetlist (representing results of
the datanodes aggregation) as arguments to the Aggref nodes in Agg plans and
letting set_plan_refs take care of Var substitution. But since this changed the
Aggref nodes on Agg plan it was not possible for the nodes above Agg node to
find matching Aggref nodes and thus set the plan references correctly. That's
why we were not able to use these optimizations in the presence of ORDER BY or
DISTINCT clauses which require nodes to be added on top of Agg node (if any).
Hence, moved this logic of substitution to set_plan_refs() and is applied only
for Agg node.
M src/backend/nodes/copyfuncs.c
M src/backend/nodes/outfuncs.c
M src/backend/optimizer/plan/pgxcplan.c
M src/backend/optimizer/plan/setrefs.c
M src/backend/optimizer/util/pgxcship.c
M src/include/optimizer/pgxcplan.h
M src/include/optimizer/pgxcship.h
M src/test/regress/expected/aggregates.out
M src/test/regress/expected/aggregates_1.out
M src/test/regress/expected/xc_FQS.out
M src/test/regress/expected/xc_groupby.out
M src/test/regress/expected/xc_having.out
M src/test/regress/sql/xc_FQS.sql
M src/test/regress/sql/xc_groupby.sql
M src/test/regress/sql/xc_having.sql
-----------------------------------------------------------------------
Summary of changes:
src/backend/nodes/copyfuncs.c | 1 -
src/backend/nodes/outfuncs.c | 1 -
src/backend/optimizer/plan/pgxcplan.c | 563 +++++++-------
src/backend/optimizer/plan/setrefs.c | 98 +++
src/backend/optimizer/util/pgxcship.c | 26 +-
src/include/optimizer/pgxcplan.h | 1 -
src/include/optimizer/pgxcship.h | 1 +
src/test/regress/expected/aggregates.out | 38 +-
src/test/regress/expected/aggregates_1.out | 36 +-
src/test/regress/expected/xc_FQS.out | 12 +-
src/test/regress/expected/xc_groupby.out | 1154 ++++++++++++----------------
src/test/regress/expected/xc_having.out | 274 +++----
src/test/regress/sql/xc_FQS.sql | 2 +-
src/test/regress/sql/xc_groupby.sql | 275 ++++----
src/test/regress/sql/xc_having.sql | 24 +-
15 files changed, 1219 insertions(+), 1287 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Ashutosh B. <ash...@us...> - 2012-10-11 07:07:11
|
Project "Postgres-XC".
The branch, master has been updated
via 7b633f16bf11ade60acef4520c614dc3dd5704b8 (commit)
from 5ccf23fc829af560f4ddb325e0a6f5eacfdfd10c (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=7b633f16bf11ade60acef4520c614dc3dd5704b8
commit 7b633f16bf11ade60acef4520c614dc3dd5704b8
Author: Ashutosh Bapat <ash...@en...>
Date: Thu Oct 11 12:28:02 2012 +0530
Move Postgres-XC specific planner code to appropriate PostgreSQL directories.
M src/backend/catalog/pg_proc.c
M src/backend/commands/schemacmds.c
M src/backend/nodes/copyfuncs.c
M src/backend/nodes/outfuncs.c
M src/backend/optimizer/path/pgxcpath.c
M src/backend/optimizer/plan/pgxcplan.c
M src/backend/optimizer/plan/planner.c
M src/backend/optimizer/plan/setrefs.c
M src/backend/parser/analyze.c
M src/backend/parser/parse_utilcmd.c
M src/backend/pgxc/Makefile
D src/backend/pgxc/plan/Makefile
D src/backend/pgxc/plan/planner.c
M src/backend/tcop/postgres.c
M src/backend/tcop/pquery.c
M src/backend/tcop/utility.c
M src/backend/utils/adt/ruleutils.c
M src/backend/utils/misc/guc.c
R091 src/include/pgxc/planner.h src/include/optimizer/pgxcplan.h
M src/include/pgxc/execRemote.h
-----------------------------------------------------------------------
Summary of changes:
src/backend/catalog/pg_proc.c | 1 -
src/backend/commands/schemacmds.c | 2 +-
src/backend/nodes/copyfuncs.c | 2 +-
src/backend/nodes/outfuncs.c | 2 +-
src/backend/optimizer/path/pgxcpath.c | 2 +-
src/backend/optimizer/plan/pgxcplan.c | 818 ++++++++++++++++++-
src/backend/optimizer/plan/planner.c | 2 +-
src/backend/optimizer/plan/setrefs.c | 2 +-
src/backend/parser/analyze.c | 2 +-
src/backend/parser/parse_utilcmd.c | 2 +-
src/backend/pgxc/Makefile | 2 +-
src/backend/pgxc/plan/Makefile | 19 -
src/backend/pgxc/plan/planner.c | 884 --------------------
src/backend/tcop/postgres.c | 2 +-
src/backend/tcop/pquery.c | 2 +-
src/backend/tcop/utility.c | 2 +-
src/backend/utils/adt/ruleutils.c | 2 +-
src/backend/utils/misc/guc.c | 2 +-
.../{pgxc/planner.h => optimizer/pgxcplan.h} | 13 +-
src/include/pgxc/execRemote.h | 2 +-
20 files changed, 833 insertions(+), 932 deletions(-)
delete mode 100644 src/backend/pgxc/plan/Makefile
delete mode 100644 src/backend/pgxc/plan/planner.c
rename src/include/{pgxc/planner.h => optimizer/pgxcplan.h} (91%)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-05 01:49:58
|
Project "Postgres-XC".
The branch, master has been updated
via 5ccf23fc829af560f4ddb325e0a6f5eacfdfd10c (commit)
from 92ffb0f81c9f73f4b07b5e375f5541d92180576e (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=5ccf23fc829af560f4ddb325e0a6f5eacfdfd10c
commit 5ccf23fc829af560f4ddb325e0a6f5eacfdfd10c
Author: Michael Paquier <mi...@ot...>
Date: Fri Oct 5 10:40:15 2012 +0900
Fix crash when COPY involves relation with no locator data
Patch and report from Nikhil Sontakke. I added a test case in xc_copy and
some comments.
M src/backend/pgxc/copy/remotecopy.c
M src/test/regress/input/xc_copy.source
M src/test/regress/output/xc_copy.source
-----------------------------------------------------------------------
Summary of changes:
src/backend/pgxc/copy/remotecopy.c | 9 ++++++---
src/test/regress/input/xc_copy.source | 5 +++++
src/test/regress/output/xc_copy.source | 5 +++++
3 files changed, 16 insertions(+), 3 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-05 01:49:53
|
Project "Postgres-XC".
The branch, REL1_0_STABLE has been updated
via d0683e5711aa899832b1b1a53a329e7d162dd2b5 (commit)
from b70e708fa6df0ce41709dc9e4a5ea89adab079ab (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=d0683e5711aa899832b1b1a53a329e7d162dd2b5
commit 5ccf23fc829af560f4ddb325e0a6f5eacfdfd10c
Author: Michael Paquier <mi...@ot...>
Date: Fri Oct 5 10:40:15 2012 +0900
Fix crash when COPY involves relation with no locator data
Patch and report from Nikhil Sontakke. I added a test case in xc_copy and
some comments.
M src/backend/pgxc/copy/remotecopy.c
M src/test/regress/input/xc_copy.source
M src/test/regress/output/xc_copy.source
-----------------------------------------------------------------------
Summary of changes:
src/backend/commands/copy.c | 16 +++++++++-------
src/test/regress/input/xc_copy.source | 5 +++++
src/test/regress/output/xc_copy.source | 5 +++++
3 files changed, 19 insertions(+), 7 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-04 05:20:48
|
Project "Postgres-XC".
The branch, master has been updated
via 92ffb0f81c9f73f4b07b5e375f5541d92180576e (commit)
from 42ddf37ca13aa27c1c8e20fabaedf3d943d8dabb (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=92ffb0f81c9f73f4b07b5e375f5541d92180576e
commit 92ffb0f81c9f73f4b07b5e375f5541d92180576e
Author: Michael Paquier <mi...@ot...>
Date: Thu Oct 4 14:21:37 2012 +0900
Correct column name of pchashalgorithm of catalog pgxc_class in docs
M doc-xc/src/sgml/catalogs.sgmlin
-----------------------------------------------------------------------
Summary of changes:
doc-xc/src/sgml/catalogs.sgmlin | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-04 05:20:41
|
Project "Postgres-XC".
The branch, REL1_0_STABLE has been updated
via b70e708fa6df0ce41709dc9e4a5ea89adab079ab (commit)
from de905b0af62a8ca07b69aa8906a1b20c0e11f7e2 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=b70e708fa6df0ce41709dc9e4a5ea89adab079ab
commit 92ffb0f81c9f73f4b07b5e375f5541d92180576e
Author: Michael Paquier <mi...@ot...>
Date: Thu Oct 4 14:21:37 2012 +0900
Correct column name of pchashalgorithm of catalog pgxc_class in docs
M doc-xc/src/sgml/catalogs.sgmlin
-----------------------------------------------------------------------
Summary of changes:
doc-xc/src/sgml/catalogs.sgmlin | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-03 06:30:18
|
Project "Postgres-XC".
The branch, master has been updated
via 42ddf37ca13aa27c1c8e20fabaedf3d943d8dabb (commit)
from 9d3446d1829bdee8ae767936cb20f339f16f5655 (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=42ddf37ca13aa27c1c8e20fabaedf3d943d8dabb
commit 42ddf37ca13aa27c1c8e20fabaedf3d943d8dabb
Author: Michael Paquier <mi...@ot...>
Date: Wed Oct 3 15:27:01 2012 +0900
Allow primary node data modification with ALTER NODE
When trying to use ALTER NODE on a primary node, node manager was complaining
about the fact that there cannot be two primary nodes even if the data altered
was something else like host IP or port number.
The origin of the error was the error handling of primary node inside node
manager. For a newly-created node, it is checked with this new node is primary
and an error is returned if there is already a node defined. For an altered
node, it is checked if a node different than the one altered is primary and
if yes an error is returned. This check was originally moved inside
check_node_options but this was a bad bet as it decentralized the primary
node error check which is really different for new and altered nodes.
M src/backend/pgxc/nodemgr/nodemgr.c
-----------------------------------------------------------------------
Summary of changes:
src/backend/pgxc/nodemgr/nodemgr.c | 31 +++++++++++++++++++++++++------
1 files changed, 25 insertions(+), 6 deletions(-)
hooks/post-receive
--
Postgres-XC
|
|
From: Michael P. <mic...@us...> - 2012-10-03 06:30:07
|
Project "Postgres-XC".
The branch, REL1_0_STABLE has been updated
via de905b0af62a8ca07b69aa8906a1b20c0e11f7e2 (commit)
from 65e90765f53ac59d1549350e48696360fe16cccc (commit)
- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=de905b0af62a8ca07b69aa8906a1b20c0e11f7e2
commit 42ddf37ca13aa27c1c8e20fabaedf3d943d8dabb
Author: Michael Paquier <mi...@ot...>
Date: Wed Oct 3 15:27:01 2012 +0900
Allow primary node data modification with ALTER NODE
When trying to use ALTER NODE on a primary node, node manager was complaining
about the fact that there cannot be two primary nodes even if the data altered
was something else like host IP or port number.
The origin of the error was the error handling of primary node inside node
manager. For a newly-created node, it is checked with this new node is primary
and an error is returned if there is already a node defined. For an altered
node, it is checked if a node different than the one altered is primary and
if yes an error is returned. This check was originally moved inside
check_node_options but this was a bad bet as it decentralized the primary
node error check which is really different for new and altered nodes.
M src/backend/pgxc/nodemgr/nodemgr.c
-----------------------------------------------------------------------
Summary of changes:
src/backend/pgxc/nodemgr/nodemgr.c | 31 +++++++++++++++++++++++++------
1 files changed, 25 insertions(+), 6 deletions(-)
hooks/post-receive
--
Postgres-XC
|
1 message has been excluded from this view by a project administrator.
