Page MenuHomeFreeBSD
Differential D2735

Change the meaning of NO_WRKSUBDIR to force a WRKDIR != WRKSRC.
ClosedPublic
Actions

Authored by mat on Jun 4 2015, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 5:31 AM
Unknown Object (File)
Thu, Nov 14, 7:42 AM
Unknown Object (File)
Mon, Nov 11, 8:10 AM
Unknown Object (File)
Sun, Nov 10, 11:48 PM
Unknown Object (File)
Sun, Nov 10, 11:41 PM
Unknown Object (File)
Sat, Nov 9, 4:05 PM
Unknown Object (File)
Thu, Nov 7, 3:00 AM
Unknown Object (File)
Sat, Oct 26, 2:00 PM
View All Files
Subscribers
antoine
bapt

Details

Reviewers
bapt
Group Reviewers
portmgr
Commits
rP400848: Fix ports that confused the meaning of WRKDIR and WRKSRC.
rP400846: Change the meaning of NO_WRKSUBDIR to force a WRKDIR != WRKSRC.
Summary

Right now, NO_WRKSUBDIR means that the extraction does not produce a subdirectory, and that everything is living in WRKDIR. It is problematic, because during the build of a port, quite a few files are created in there, and then, a stage directory, where everything is installed, and then a pkg directory where the package is created.

With this, NO_WRKSUBDIR will extract the distfiles directly into WRKSRC instead of WRKDIR.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mat updated this revision to Diff 5951.Jun 4 2015, 8:59 PM
mat retitled this revision from to Change the meaning of NO_WRKSUBDIR to force a WRKDIR != WRKSRC..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
Herald added a reviewer: portmgr. · View Herald TranscriptJun 4 2015, 8:59 PM
bapt accepted this revision.Jun 4 2015, 9:04 PM
bapt added a reviewer: bapt.
bapt added a subscriber: bapt.

accepted only if it passes an exp-run

This revision is now accepted and ready to land.Jun 4 2015, 9:04 PM
mat updated this revision to Diff 5954.Jun 4 2015, 9:14 PM
mat edited edge metadata.

Update the documentation.

This revision now requires review to proceed.Jun 4 2015, 9:14 PM
mat updated this object.Jun 4 2015, 10:15 PM
mat edited edge metadata.
mat updated this revision to Diff 5961.Jun 5 2015, 8:55 AM

Include lha and zip in the use of EXTRACT_WRKDIR.

mat updated this revision to Diff 9735.Oct 27 2015, 2:12 PM

Rebase.

antoine added a subscriber: antoine.Oct 28 2015, 6:55 PM
antoine added inline comments.
Mk/bsd.port.mk
529 ↗(On Diff #9735)

there is a strange character in this line

mat added inline comments.Oct 28 2015, 7:44 PM
Mk/bsd.port.mk
529 ↗(On Diff #9735)

Mmm, yes, there was a non breaking space, fixed.

mat updated this revision to Diff 9773.Oct 28 2015, 7:44 PM
  • some non breaking space got included.
mat marked 2 inline comments as done.Oct 28 2015, 7:44 PM
mat updated this revision to Diff 9819.Oct 30 2015, 12:22 PM
  • Fix linux ports, I think.
mat updated this revision to Diff 9903.Nov 3 2015, 11:41 AM

Rebase and reduce commits.

mat updated this revision to Diff 9905.Nov 3 2015, 1:55 PM

once more.

Closed by commit rP400846: Change the meaning of NO_WRKSUBDIR to force a WRKDIR != WRKSRC. (authored by mat). · Explain WhyNov 5 2015, 12:43 PM
Closed by commit rP400848: Fix ports that confused the meaning of WRKDIR and WRKSRC. (authored by mat). · Explain Why
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 206 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
head/
archivers/
paq/
2 lines
szip/
4 lines
undms/
4 lines
astro/
geographiclib/
2 lines
audio/
chordpack/
6 lines
cue2toc/
4 lines
benchmarks/
raidtest/
4 lines
stream/
2 lines
biology/
gff2ps/
10 lines
chinese/
CJKUnifonts/
4 lines
xpdf/
2 lines
comms/
cdr_read/
4 lines
converters/
unix2dos/
6 lines
devel/
apr1/
4 lines
cvs2html/
2 lines
cweb/
2 lines
easygit/
6 lines
libcii/
4 lines
libdlmalloc/
6 lines
mingw32-bin-msvcrt/
2 lines
py-json-py/
4 lines
py-urlimport/
4 lines
ruby-dialogs/
4 lines
sedsed/
2 lines
sfio/
14 lines
dns/
dnswalk/
14 lines
ipcheck/
4 lines
editors/
omegaT/
4 lines
emulators/
linux_base-c6/
12 lines
linux_base-f10/
4 lines
qmc2/
2 lines
simh/
8 lines
yape/
2 lines
games/
alephone-data/
4 lines
alephone-scenarios/
2 lines
arkanoidsb/
1 line
bogged/
2 lines
crafty-open-enormous/
4 lines
crafty-open-large/
8 lines
crafty-open-medium/
4 lines
doom-data/
4 lines
doom-hacx/
3 lines
doom-wolfendoom/
6 lines
legends/
2 lines
linux-darwinia-demo/
3 lines
linux-doom3/
4 lines
linux-quake3-demo/
3 lines
linux-quake3/
5 lines
linux-quake4-demo/
4 lines
linux-quake4/
4 lines
linux-uplink-demo/
3 lines
quake-dpmod/
4 lines
quake2-data/
12 lines
quake2-rogue/
3 lines
quake2-xatrix/
4 lines
quake3-data/
6 lines
rfksay/
6 lines
robocode/
2 lines
thudboard/
6 lines
traindirector/
2 lines
xasteroids/
2 lines
graphics/
fujiplay/
4 lines
geoapi/
4 lines
gimp-jagged-border-script/
2 lines
mapyrus/
6 lines
openjump/
1 line
pstoepsi/
14 lines
springgraph/
2 lines
irc/
irssi-dcc_send_limiter/
8 lines
japanese/
VTPSfont/
4 lines
a2ps/
6 lines
bugzilla44/
4 lines
edict-utf-8/
4 lines
edict/
4 lines
font-ayu18/
1 line
font-ayu20/
1 line
font-elisa10/
3 lines
font-elisa8/
1 line
font-jisx0213/
2 lines
font-kaname12/
2 lines
font-kanji18/
5 lines
font-mona-ttf/
2 lines
gskk/
2 lines
jcode.pl/
4 lines
skk-jisyo/
10 lines
yc.el/
4 lines
zipcodes/
4 lines
java/
eclipse-ecj/
4 lines
eclipse-pydev/
4 lines
javavmwrapper/
14 lines
jtiger/
12 lines
korean/
kaistfonts/
6 lines
ko.TeX-fonts-base/
4 lines
ko.TeX-fonts-extra/
6 lines
ko.TeX/
34 lines
lang/
cmucl-extra/
2 lines
cmucl/
10 lines
linux-j/
4 lines
smlnj/
44 lines
tcl-manual/
6 lines
mail/
gml/
4 lines
imaptools/
2 lines
mb2md/
2 lines
msgconvert/
2 lines
py-cyruslib/
5 lines
rlytest/
2 lines
x-face-e21/
2 lines
xcite/
2 lines
math/
jts/
6 lines
lll_spect/
8 lines
physcalc/
2 lines
solitaire/
3 lines
misc/
amfm/
2 lines
astrolog/
4 lines
colwide/
4 lines
figlet-fonts/
22 lines
kenny/
8 lines
metalink-editor/
2 lines
umodunpack/
4 lines
multimedia/
linux-tsmuxer/
2 lines
net-mgmt/
icmpquery/
6 lines
nagios-check_dhcp.pl/
4 lines
nagios-check_tftp/
6 lines
net-p2p/
frost/
2 lines
vuze/
2 lines
net/
dictd-database/
10 lines
linux-f10-nss_ldap/
22 lines
lla/
2 lines
netpipes/
2 lines
radreport/
6 lines
spideroak/
26 lines
tcpshow/
6 lines
news/
c-nocem/
2 lines
nnap/
4 lines
palm/
pilot_makedoc/
8 lines
print/
adobe-cmaps/
4 lines
enscriptfonts/
8 lines
ghostscript7-commfont/
1 line
texlive-texmf/
4 lines
txtbdf2ps/
2 lines
russian/
p5-XML-Parser-encodings/
14 lines
science/
checkmol/
2 lines
medit/
2 lines
mol2ps/
2 lines
security/
chaosreader/
8 lines
ipfilter2dshield/
8 lines
l0phtcrack/
6 lines
pxytest/
2 lines
py-htpasswd/
2 lines
sig2dot/
2 lines
sshblock/
2 lines
unhide/
6 lines
shells/
v7sh/
2 lines
sysutils/
3dm/
2 lines
copytape/
2 lines
pdixtract/
4 lines
pstree/
6 lines
sb16config/
2 lines
setcdboot/
4 lines
storcli/
6 lines
vils/
2 lines
textproc/
clit/
12 lines
diffsplit/
6 lines
foiltex/
8 lines
jarnal/
14 lines
ppower4/
8 lines
saxon-devel/
4 lines
vietnamese/
vnroff/
8 lines
www/
bareos-webui/
1 line
cgi-lib.pl/
2 lines
closure-compiler/
2 lines
demoroniser/
4 lines
efront/
4 lines
fira-webfont/
4 lines
htmlpp/
16 lines
jawstats/
10 lines
14 lines
linux-c6-flashplugin11/
12 lines
mimetex/
2 lines
ruby-wgettsv/
6 lines
scloader/
2 lines
skytemplate/
3 lines
x11-fonts/
fira/
2 lines
noto/
2 lines
proggy_fonts/
4 lines
symbola/
6 lines
tmu/
2 lines
wqy/
72 lines
x11-themes/
gnome-icons-aqua-fusion/
2 lines
gnome-icons-crystal/
4 lines
gnome-icons-dropline-neu/
2 lines
gnome-icons-dropline-nou/
2 lines
gnome-icons-elementary/
2 lines
gnome-icons-gentoo-test/
2 lines
gnome-icons-gion/
2 lines
gnome-icons-iris/
2 lines
gnome-icons-noia-full/
2 lines
gnome-icons-noia-warm/
2 lines
gnome-icons-refined/
2 lines
gnome-icons-slick/
2 lines
gnome-icons-snow-apple/
2 lines
gnome-icons-stylish/
2 lines
gnome-icons-ximian-south/
3 lines
gnome-icons/
10 lines
x11/
xkbctrl/
4 lines
xnodecor/
6 lines

Diff 9957

View Options

head/archivers/paq/Makefile

View Options

head/archivers/szip/Makefile

View Options

head/archivers/undms/Makefile

View Options

head/astro/geographiclib/Makefile

View Options

head/audio/chordpack/Makefile

View Options

head/audio/cue2toc/Makefile

View Options

head/benchmarks/raidtest/Makefile

View Options

head/benchmarks/stream/Makefile

View Options

head/biology/gff2ps/Makefile

View Options

head/chinese/CJKUnifonts/Makefile

View Options

head/chinese/xpdf/Makefile

View Options

head/comms/cdr_read/Makefile

View Options

head/converters/unix2dos/Makefile

View Options

head/devel/apr1/Makefile

View Options

head/devel/cvs2html/Makefile

View Options

head/devel/cweb/Makefile

View Options

head/devel/easygit/Makefile

View Options

head/devel/libcii/Makefile

View Options

head/devel/libdlmalloc/Makefile

View Options

head/devel/mingw32-bin-msvcrt/Makefile

View Options

head/devel/py-json-py/Makefile

View Options

head/devel/py-urlimport/Makefile

View Options

head/devel/ruby-dialogs/Makefile

View Options

head/devel/sedsed/Makefile

View Options

head/devel/sfio/Makefile

View Options

head/dns/dnswalk/Makefile

View Options

head/dns/ipcheck/Makefile

View Options

head/editors/omegaT/Makefile

View Options

head/emulators/linux_base-c6/Makefile

View Options

head/emulators/linux_base-f10/Makefile

View Options

head/emulators/qmc2/Makefile

View Options

head/emulators/simh/Makefile

View Options

head/emulators/yape/Makefile

View Options

head/games/alephone-data/Makefile

View Options

head/games/alephone-scenarios/Makefile

View Options

head/games/arkanoidsb/Makefile

View Options

head/games/bogged/Makefile

View Options

head/games/crafty-open-enormous/Makefile

View Options

head/games/crafty-open-large/Makefile

View Options

head/games/crafty-open-medium/Makefile

View Options

head/games/doom-data/Makefile

View Options

head/games/doom-hacx/Makefile

View Options

head/games/doom-wolfendoom/Makefile

View Options

head/games/legends/Makefile

View Options

head/games/linux-darwinia-demo/Makefile

View Options

head/games/linux-doom3/Makefile

View Options

head/games/linux-quake3-demo/Makefile

View Options

head/games/linux-quake3/Makefile

View Options

head/games/linux-quake4-demo/Makefile

View Options

head/games/linux-quake4/Makefile

View Options

head/games/linux-uplink-demo/Makefile

View Options

head/games/quake-dpmod/Makefile

View Options

head/games/quake2-data/Makefile

View Options

head/games/quake2-rogue/Makefile

View Options

head/games/quake2-xatrix/Makefile

View Options

head/games/quake3-data/Makefile

View Options

head/games/rfksay/Makefile

View Options

head/games/robocode/Makefile

View Options

head/games/thudboard/Makefile

View Options

head/games/traindirector/Makefile

View Options

head/games/xasteroids/Makefile

View Options

head/graphics/fujiplay/Makefile

View Options

head/graphics/geoapi/Makefile

View Options

head/graphics/gimp-jagged-border-script/Makefile

View Options

head/graphics/mapyrus/Makefile

View Options

head/graphics/openjump/Makefile

View Options

head/graphics/pstoepsi/Makefile

View Options

head/graphics/springgraph/Makefile

View Options

head/irc/irssi-dcc_send_limiter/Makefile

View Options

head/japanese/VTPSfont/Makefile

View Options

head/japanese/a2ps/Makefile

View Options

head/japanese/bugzilla44/Makefile

View Options

head/japanese/edict-utf-8/Makefile

View Options

head/japanese/edict/Makefile

View Options

head/japanese/font-ayu18/Makefile

View Options

head/japanese/font-ayu20/Makefile

View Options

head/japanese/font-elisa10/Makefile

View Options

head/japanese/font-elisa8/Makefile

View Options

head/japanese/font-jisx0213/Makefile

View Options

head/japanese/font-kaname12/Makefile

View Options

head/japanese/font-kanji18/Makefile

View Options

head/japanese/font-mona-ttf/Makefile

View Options

head/japanese/gskk/Makefile

View Options

head/japanese/jcode.pl/Makefile

View Options

head/japanese/skk-jisyo/Makefile

View Options

head/japanese/yc.el/Makefile

View Options

head/japanese/zipcodes/Makefile

View Options

head/java/eclipse-ecj/Makefile

View Options

head/java/eclipse-pydev/Makefile

View Options

head/java/javavmwrapper/Makefile

View Options

head/java/jtiger/Makefile

View Options

head/korean/kaistfonts/Makefile

View Options

head/korean/ko.TeX-fonts-base/Makefile

View Options

head/korean/ko.TeX-fonts-extra/Makefile

View Options

head/korean/ko.TeX/Makefile

View Options

head/lang/cmucl-extra/Makefile

View Options

head/lang/cmucl/Makefile

View Options

head/lang/linux-j/Makefile

View Options

head/lang/smlnj/Makefile

View Options

head/lang/tcl-manual/Makefile

View Options

head/mail/gml/Makefile

View Options

head/mail/imaptools/Makefile

View Options

head/mail/mb2md/Makefile

View Options

head/mail/msgconvert/Makefile

View Options

head/mail/py-cyruslib/Makefile

View Options

head/mail/rlytest/Makefile

View Options

head/mail/x-face-e21/Makefile

View Options

head/mail/xcite/Makefile

View Options

head/math/jts/Makefile

View Options

head/math/lll_spect/Makefile

View Options

head/math/physcalc/Makefile

View Options

head/math/solitaire/Makefile

View Options

head/misc/amfm/Makefile

View Options

head/misc/astrolog/Makefile

View Options

head/misc/colwide/Makefile

View Options

head/misc/figlet-fonts/Makefile

View Options

head/misc/kenny/Makefile

View Options

head/misc/metalink-editor/Makefile

View Options

head/misc/umodunpack/Makefile

View Options

head/multimedia/linux-tsmuxer/Makefile

View Options

head/net-mgmt/icmpquery/Makefile

View Options

head/net-mgmt/nagios-check_dhcp.pl/Makefile

View Options

head/net-mgmt/nagios-check_tftp/Makefile

View Options

head/net-p2p/frost/Makefile

View Options

head/net-p2p/vuze/Makefile

View Options

head/net/dictd-database/Makefile

View Options

head/net/linux-f10-nss_ldap/Makefile

View Options

head/net/lla/Makefile

View Options

head/net/netpipes/Makefile

View Options

head/net/radreport/Makefile

View Options

head/net/spideroak/Makefile

View Options

head/net/tcpshow/Makefile

View Options

head/news/c-nocem/Makefile

View Options

head/news/nnap/Makefile

View Options

head/palm/pilot_makedoc/Makefile

View Options

head/print/adobe-cmaps/Makefile

View Options

head/print/enscriptfonts/Makefile

View Options

head/print/ghostscript7-commfont/Makefile

View Options

head/print/texlive-texmf/Makefile

View Options

head/print/txtbdf2ps/Makefile

View Options

head/russian/p5-XML-Parser-encodings/Makefile

View Options

head/science/checkmol/Makefile

View Options

head/science/medit/Makefile

View Options

head/science/mol2ps/Makefile

View Options

head/security/chaosreader/Makefile

View Options

head/security/ipfilter2dshield/Makefile

View Options

head/security/l0phtcrack/Makefile

View Options

head/security/pxytest/Makefile

View Options

head/security/py-htpasswd/Makefile

View Options

head/security/sig2dot/Makefile

View Options

head/security/sshblock/Makefile

View Options

head/security/unhide/Makefile

View Options

head/shells/v7sh/Makefile

View Options

head/sysutils/3dm/Makefile

View Options

head/sysutils/copytape/Makefile

View Options

head/sysutils/pdixtract/Makefile

View Options

head/sysutils/pstree/Makefile

View Options

head/sysutils/sb16config/Makefile

View Options

head/sysutils/setcdboot/Makefile

View Options

head/sysutils/storcli/Makefile

View Options

head/sysutils/vils/Makefile

View Options

head/textproc/clit/Makefile

View Options

head/textproc/diffsplit/Makefile

View Options

head/textproc/foiltex/Makefile

View Options

head/textproc/jarnal/Makefile

View Options

head/textproc/ppower4/Makefile

View Options

head/textproc/saxon-devel/Makefile

View Options

head/vietnamese/vnroff/Makefile

View Options

head/www/bareos-webui/Makefile

View Options

head/www/cgi-lib.pl/Makefile

View Options

head/www/closure-compiler/Makefile

View Options

head/www/demoroniser/Makefile

View Options

head/www/efront/Makefile

View Options

head/www/fira-webfont/Makefile

View Options

head/www/htmlpp/Makefile

View Options

head/www/jawstats/Makefile

View Options

head/www/jawstats/pkg-plist

View Options

head/www/linux-c6-flashplugin11/Makefile

View Options

head/www/mimetex/Makefile

View Options

head/www/ruby-wgettsv/Makefile

View Options

head/www/scloader/Makefile

View Options

head/www/skytemplate/Makefile

View Options

head/x11-fonts/fira/Makefile

View Options

head/x11-fonts/noto/Makefile

View Options

head/x11-fonts/proggy_fonts/Makefile

View Options

head/x11-fonts/symbola/Makefile

View Options

head/x11-fonts/tmu/Makefile

View Options

head/x11-fonts/wqy/Makefile

View Options

head/x11-themes/gnome-icons-aqua-fusion/Makefile

View Options

head/x11-themes/gnome-icons-crystal/Makefile

View Options

head/x11-themes/gnome-icons-dropline-neu/Makefile

View Options

head/x11-themes/gnome-icons-dropline-nou/Makefile

View Options

head/x11-themes/gnome-icons-elementary/Makefile

View Options

head/x11-themes/gnome-icons-gentoo-test/Makefile

View Options

head/x11-themes/gnome-icons-gion/Makefile

View Options

head/x11-themes/gnome-icons-iris/Makefile

View Options

head/x11-themes/gnome-icons-noia-full/Makefile

View Options

head/x11-themes/gnome-icons-noia-warm/Makefile

View Options

head/x11-themes/gnome-icons-refined/Makefile

View Options

head/x11-themes/gnome-icons-slick/Makefile

View Options

head/x11-themes/gnome-icons-snow-apple/Makefile

View Options

head/x11-themes/gnome-icons-stylish/Makefile

View Options

head/x11-themes/gnome-icons-ximian-south/Makefile

View Options

head/x11-themes/gnome-icons/bsd.gnome-icons.mk

View Options

head/x11/xkbctrl/Makefile

View Options

head/x11/xnodecor/Makefile