-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Description
Context
I added Custom Elements with shadow root via custom elements because I don't want the styles of mkdocs has influence on forms I am adding. When I have a form inside my custom component, the global keyboard handler catches some keys I am typing like s
and takes focus to search.
The reason is if there is input focused inside the shadow root, the parent's document.activeElement
would point to the custom element itself, not to it's underlying element.
Since 'the bug' is caused by extra javascript, I cannot mark it as a bug, so I am asking about adding support for custom elements.
Description
While having additional functionality via extra_javascript is a great feature, it lacks a full support for adding custom elements. I was able to add the custom element, but the keyboard shortcut is not aware about such type of element.
There is a check for activeElement which works differently for elements with shadowRoot. I am asking to add support for such kind of elements here:
mkdocs-material/src/templates/assets/javascripts/browser/element/_/index.ts
Lines 116 to 120 in 4498245
export function getActiveElement(): HTMLElement | undefined { | |
return document.activeElement instanceof HTMLElement | |
? document.activeElement || undefined | |
: undefined | |
} |
The active element of shadowRoot can be accessed via document.activeElement.shadowRoot.activeElement
.
Related links
Use Cases
It will allow to have forms inside custom elements
Visuals
No response
Before submitting
- I have read and followed the change request guidelines.
- I have verified that my idea is a change request and not a bug report.
- I have ensured that, to the best of my knowledge, my idea will benefit the entire community.
- I have included relevant links to the documentation, related issues, and discussions to underline the need for my idea.