Using blog and tags plugins in combination results in wrong links to Blog index

[vedranmiletic]

Context

No response

Bug description

When blog and tags plugins are enabled together, the links to Blog index will be rendered as linking to the last page of the index instead of the first page.

Related links

• Reporting a bug
• Setting up tags
• Setting up a blog

Reproduction

9.2.7-using-blog-and-tags-in-combination.zip

Steps to reproduce

1. mkdocs serve
2. observe that the link on the Home page points to the second page of the Blog index
3. remove tags plugin configuration from plugins section in mkdocs.yml
4. observe that the same link is now generated correctly

Browser

No response

Before submitting

• I have read and followed the bug reporting guidelines.
• I have attached links to the documentation, and possibly related issues and discussions.
• I assure that I have removed all customizations before submitting this bug report.
• I have attached a .zip file with a minimal reproduction.

[squidfunk]

Fixed in 84cb91b. I think I found all cases and refactored how paginated views are handled during rendering with a more resilient approach. The problem reported was not exclusive to the tags plugin, but also happened when you went to the second page of the archive, and then clicked on "Latest posts", also ending up on the last page.

[vedranmiletic]

This commit actually causes a regression, which in my case manifests as ERROR - Error building page 'blog/archive/2010.md': Page(title='2010', url='/blog/archive/2010/') is not in list. I will prepare a minimal example for that one.

[vedranmiletic]

9.2.7-url-not-in-list-regression.zip

Note that I am not really using version 9.2.7 here, but the git master (and I have independently bisected the bad commit to 84cb91b). The error I get is:

INFO    -  Building documentation...
INFO    -  Cleaning site directory
ERROR   -  Error building page 'blog/archive/1990.md': Page(title='1990', url='/blog/archive/1990/') is not in list
Traceback (most recent call last):
  File "/usr/local/bin/mkdocs", line 8, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/mkdocs/__main__.py", line 270, in serve_command
    serve.serve(**kwargs)
  File "/usr/local/lib/python3.9/site-packages/mkdocs/commands/serve.py", line 86, in serve
    builder(config)
  File "/usr/local/lib/python3.9/site-packages/mkdocs/commands/serve.py", line 67, in builder
    build(config, live_server=None if is_clean else server, dirty=is_dirty)
  File "/usr/local/lib/python3.9/site-packages/mkdocs/commands/build.py", line 349, in build
    _build_page(
  File "/usr/local/lib/python3.9/site-packages/mkdocs/commands/build.py", line 222, in _build_page
    context = config.plugins.on_page_context(context, page=page, config=config, nav=nav)
  File "/usr/local/lib/python3.9/site-packages/mkdocs/plugins.py", line 583, in on_page_context
    return self.run_event('page_context', context, page=page, config=config, nav=nav)
  File "/usr/local/lib/python3.9/site-packages/mkdocs/plugins.py", line 507, in run_event
    result = method(item, **kwargs)
  File "/home/vedranmiletic/.local/lib/python3.9/site-packages/material/plugins/blog/plugin.py", line 347, in on_page_context
    items[items.index(view)] = page
ValueError: Page(title='1990', url='/blog/archive/1990/') is not in list

[squidfunk]

Thanks, looking into it.

[squidfunk]

Fixed in 682d176. Thanks again for testing and providing the minimal reproduction – it only happened with 3 pages or more. I've tested the head of master against all reproductions we received related to the blog and think that it's finally stable... until the next bug appears 😅 If you can confirm that it works for you, we can release it today with the other fixes.

[vedranmiletic]

If you can confirm that it works for you, we can release it today with the other fixes.

Unfortunately not, the original bug seems to be back, both on the test case and real-world sites. I made sure several times that I am using the right version. Can you check on your side?

[squidfunk]

Yes, the bug is back. I only checked the links in the navigation and they were all correct. I'll take a look. This is so exceptionally tricky to get right in all possible constellations...

[squidfunk]

... and the next attempt in fc566cf. The links should now all be correct, unless I'm missing something. I've also, again, made sure this didn't break URLs for previously fixed issues.

[squidfunk]

@vedranmiletic when you find some time, it would be great if you could verify if your issue is now fixed. We're waiting with the next release until this issue is fixed, so it would be awesome if you could check if the problem is gone ☺️