Skip to content

Remove 12.4 x86 builds and 12.6 sbsa builds from nightly #148895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove 12.4 x86 builds and 12.6 sbsa builds from nightly #148895

wants to merge 1 commit into from

Conversation

tinglvv
Copy link
Collaborator

@tinglvv tinglvv commented Mar 10, 2025 •
edited
Loading

@tinglvv tinglvv requested a review from a team as a code owner March 10, 2025 17:58
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 10, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148895

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 78 Pending, 3 Unrelated Failures

As of commit 662d4e9 with merge base 2ec9ace (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@tinglvv tinglvv added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Mar 10, 2025
@tinglvv tinglvv mentioned this pull request Mar 10, 2025
Open
26 tasks
atalman
atalman approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman
Copy link
Contributor

atalman commented Mar 10, 2025

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 10, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@atalman
Copy link
Contributor

atalman commented Mar 10, 2025

@pytorchmergebot merge -f "pr sanity check can be ignored, lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman atalman mentioned this pull request Mar 13, 2025
Merged
malfet pushed a commit to pytorch/test-infra that referenced this pull request Mar 13, 2025
@atalman
Remove cuda 12.6 aarch (#6409)
bf74224 
Aarch64 CUDA 12.6 builds were removed from pytorch/pytorch by
pytorch/pytorch#148895
@atalman atalman mentioned this pull request Mar 19, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Mar 19, 2025
@atalman @pytorchmergebot
Modify cuda aarch64 install for cudnn and nccl. Cleanup aarch64 cuda …
c9de76a 
…12.6 docker (#149540)

1. Use NCCL_VERSION=v2.26.2-1 . Fixes nccl cuda aarch64 related failure we see here: https://github.com/pytorch/pytorch/actions/runs/13955856471/job/39066681549?pr=149443 . After landing: #149351
TODO: Followup required to unify NCCL definitions across the x86 and aarch64 builds

3. Cleanup Remove older CUDA versions for aarch64 builds . CUDA 12.6 where removed by: #148895
Pull Request resolved: #149540
Approved by: https://github.com/seemethere, https://github.com/malfet, https://github.com/nWEIdia
atalman added a commit to atalman/pytorch that referenced this pull request Mar 20, 2025
@atalman
Modify cuda aarch64 install for cudnn and nccl. Cleanup aarch64 cuda …
e826eef 
…12.6 docker (pytorch#149540)

1. Use NCCL_VERSION=v2.26.2-1 . Fixes nccl cuda aarch64 related failure we see here: https://github.com/pytorch/pytorch/actions/runs/13955856471/job/39066681549?pr=149443 . After landing: pytorch#149351
TODO: Followup required to unify NCCL definitions across the x86 and aarch64 builds

3. Cleanup Remove older CUDA versions for aarch64 builds . CUDA 12.6 where removed by: pytorch#148895
Pull Request resolved: pytorch#149540
Approved by: https://github.com/seemethere, https://github.com/malfet, https://github.com/nWEIdia
atalman added a commit to atalman/pytorch that referenced this pull request Mar 26, 2025
@atalman
Modify cuda aarch64 install for cudnn and nccl. Cleanup aarch64 cuda …
7021a63 
…12.6 docker (pytorch#149540)

1. Use NCCL_VERSION=v2.26.2-1 . Fixes nccl cuda aarch64 related failure we see here: https://github.com/pytorch/pytorch/actions/runs/13955856471/job/39066681549?pr=149443 . After landing: pytorch#149351
TODO: Followup required to unify NCCL definitions across the x86 and aarch64 builds

3. Cleanup Remove older CUDA versions for aarch64 builds . CUDA 12.6 where removed by: pytorch#148895
Pull Request resolved: pytorch#149540
Approved by: https://github.com/seemethere, https://github.com/malfet, https://github.com/nWEIdia
malfet pushed a commit that referenced this pull request Mar 26, 2025
@atalman
[cherry-pick] Modify cuda aarch64 install for cudnn and nccl. Cleanup…
d80afc0 
… aarch64 cuda 12.6 docker #149540 (#149624)

Modify cuda aarch64 install for cudnn and nccl. Cleanup aarch64 cuda 12.6 docker (#149540)

1. Use NCCL_VERSION=v2.26.2-1 . Fixes nccl cuda aarch64 related failure we see here: https://github.com/pytorch/pytorch/actions/runs/13955856471/job/39066681549?pr=149443 . After landing: #149351
TODO: Followup required to unify NCCL definitions across the x86 and aarch64 builds

3. Cleanup Remove older CUDA versions for aarch64 builds . CUDA 12.6 where removed by: #148895
Pull Request resolved: #149540
Approved by: https://github.com/seemethere, https://github.com/malfet, https://github.com/nWEIdia
atalman added a commit to atalman/test-infra that referenced this pull request Apr 2, 2025
@atalman
Remove cuda 12.6 aarch (pytorch#6409)
fdfe63d 
Aarch64 CUDA 12.6 builds were removed from pytorch/pytorch by
pytorch/pytorch#148895
amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025
@atalman @amathewc
Modify cuda aarch64 install for cudnn and nccl. Cleanup aarch64 cuda …
bd023d6 
…12.6 docker (pytorch#149540)

1. Use NCCL_VERSION=v2.26.2-1 . Fixes nccl cuda aarch64 related failure we see here: https://github.com/pytorch/pytorch/actions/runs/13955856471/job/39066681549?pr=149443 . After landing: pytorch#149351
TODO: Followup required to unify NCCL definitions across the x86 and aarch64 builds

3. Cleanup Remove older CUDA versions for aarch64 builds . CUDA 12.6 where removed by: pytorch#148895
Pull Request resolved: pytorch#149540
Approved by: https://github.com/seemethere, https://github.com/malfet, https://github.com/nWEIdia
@anumol-baby anumol-baby mentioned this pull request Jun 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tinglvv @atalman @pytorchmergebot @pytorchbot