Skip to content

Turn on prologue fusion #147008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Turn on prologue fusion #147008

wants to merge 10 commits into from

Conversation

eellison
Copy link
Contributor

@eellison eellison commented Feb 12, 2025 •
edited
Loading

@eellison
Update
95211bd 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147008

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3585499 with merge base f95bdf5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

eellison
eellison commented Feb 12, 2025
View reviewed changes
torch/_inductor/config.py
@@ -39,6 +39,17 @@ def bundle_triton_into_fx_graph_cache_default() -> Optional[bool]:
)


def prologue_fusion_enabled() -> bool:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @c00w is there a way to do this with Config ? I see justknob arg but I don't see a way to compare the integer value of it to tell if its enabled or not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all stylistic.

VERSION ints in JK are working around a missing feature in JK (enable based on build stamp). My suggestion is just use Config, and don't bother with versions. (If you want to turn something new on, just use a new JK, don't keep reusing the same one). However, as a matter of style other people have different preferences and do it differently.

@eellison eellison added the topic: not user facing topic category label Feb 12, 2025
masnesral
masnesral reviewed Feb 12, 2025
View reviewed changes
@eellison
Update
0d8c20a 
[ghstack-poisoned]
@eellison eellison requested a review from masnesral February 12, 2025 19:36
@eellison
Update
6703748 
[ghstack-poisoned]
masnesral
masnesral approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@masnesral masnesral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 12, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / unit-test / cuda12.4-py3.10-gcc9-sm86 / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@eellison
Update
166359f 
[ghstack-poisoned]
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@eellison
Update
6480f85 
[ghstack-poisoned]
@eellison eellison mentioned this pull request Feb 12, 2025
Closed
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@eellison
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: pull / win-vs2019-cpu-py3 / build, trunk / win-vs2019-cpu-py3 / build, trunk / win-vs2019-cuda12.4-py3 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (inductor_torchbench_cpu_smoketest_perf, 1, 1, linux.24xl.spr-metal)

Details for Dev Infra team Raised by workflow job

@eellison
Update on "Turn on prologue fusion"
b0b27cb 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 amjames chauhang aakhundov

[ghstack-poisoned]
eellison added a commit that referenced this pull request Feb 13, 2025
@eellison
Turn on prologue fusion
95b4e2e 
ghstack-source-id: 737051d
Pull Request resolved: #147008
@eellison
Update on "Turn on prologue fusion"
740c3c1 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 amjames chauhang aakhundov

[ghstack-poisoned]
@eellison eellison mentioned this pull request Feb 13, 2025
Closed
@eellison
Update
f903013 
[ghstack-poisoned]
@eellison
Update on "Turn on prologue fusion"
bbb5f3a 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 amjames chauhang aakhundov

[ghstack-poisoned]
@eellison
Update on "Turn on prologue fusion"
3585499 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 amjames chauhang aakhundov

[ghstack-poisoned]
eellison added a commit that referenced this pull request Feb 14, 2025
@eellison
Turn on prologue fusion
98fe70f 
ghstack-source-id: 937ada4
Pull Request resolved: #147008
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

desai0007 pushed a commit to desai0007/test-repo-pytorch that referenced this pull request Feb 26, 2025
@eellison
Turn on prologue fusion
c417bdb 
ghstack-source-id: bd456db
Pull Request resolved: pytorch/pytorch#147008
@github-actions github-actions bot deleted the gh/eellison/760/head branch March 25, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c00w c00w c00w left review comments

@masnesral masnesral masnesral approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor release notes: inductor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eellison @pytorchmergebot @c00w @masnesral