setup: remove upper bound from python_requires #9685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A cap was recently added to denote the upper bound of python support for pydantic v1. Further research, however, has determined that `python_requires` was not developed with an upper bound in mind [0] and may actually cause some dependency solvers to silently fall back to older versions where there is no cap, and thus presumed support for the user's python. For now, remove the upper bound. [0]: https://discuss.python.org/t/requires-python-upper-limits/12663 Signed-off-by: Vincent Fazio <[email protected]>
sydney-runkle
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cap was recently added to denote the upper bound of python support for pydantic v1.
Further research, however, has determined that
python_requireswas not developed with an upper bound in mind 1 and may actually cause some dependency solvers to silently fall back to older versions where there is no cap, and thus presumed support for the user's python.For now, remove the upper bound.
Change Summary
Related issue number
fix #9663
Checklist
skip change file check
Footnotes
https://discuss.python.org/t/requires-python-upper-limits/12663 ↩