DISCUSSION: Refactor and split sources.py?

[ezwiefel]

I've written a GCP Secret Manager source and I'd like to contribute it... but I'm worried it'll make source.py a bit long...

I'm wondering if you'd all be open to refactoring source.py into a subfolder? I think it'd make it easier to add new sources in the future.

Made something like this?

pydantic_settings/
├── __init__.py
├── main.py
├── py.typed
├── utils.py
├── version.py
└── sources/
    ├── __init__.py          # Re-exports all public components
    ├── base.py              # Base classes and core functionality
    ├── types.py             # Shared type definitions
    ├── utils.py             # Shared utility functions
    └── providers/           # Individual source implementations
        ├── __init__.py
        ├── secrets.py
        ├── env.py
        ├── dotenv.py
        ├── json.py
        ├── toml.py
        ├── pyproject.py
        ├── yaml.py
        ├── azure.py
        └── cli.py

I'd be happy to open a PR with the refactor if this approach works for all of you.

[hramezani]

Thanks @ezwiefel for bringing this.
Agree, the source file is too big and hard too follow.
I would be happy to review prs. Please remember to not do all the changes in one big pr. I would like small prs

[ezwiefel]

Sounds good, @hramezani, but I'm not sure how to do small prs for this change, since I'll be redirecting references to sources.py to a sourcesfolder. Any suggestions?