Correcly handle comments appended to nameserver declarations #14658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We need to ensure we correctly filter out appended comments in resolv.conf Modifications: - Skip comments - Add unit test Result: Fixes #14514
099bda8 to
0ffe80e
Compare
bryce-anderson
approved these changes
Jan 13, 2025
resolver-dns/src/main/java/io/netty/resolver/dns/ResolvConf.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Bryce Anderson <[email protected]>
normanmaurer
added a commit
that referenced
this pull request
Jan 13, 2025
Motivation: We need to ensure we correctly filter out appended comments in resolv.conf Modifications: - Skip comments - Add unit test Result: Fixes #14514 --------- Co-authored-by: Bryce Anderson <[email protected]>
normanmaurer
added a commit
that referenced
this pull request
Jan 13, 2025
…#14663) Motivation: We need to ensure we correctly filter out appended comments in resolv.conf Modifications: - Skip comments - Add unit test Result: Fixes #14514 Co-authored-by: Bryce Anderson <[email protected]>
normanmaurer
added a commit
that referenced
this pull request
Jan 13, 2025
…#14663) Motivation: We need to ensure we correctly filter out appended comments in resolv.conf Modifications: - Skip comments - Add unit test Result: Fixes #14514 Co-authored-by: Bryce Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to ensure we correctly filter out appended comments in resolv.conf
Modifications:
Result:
Fixes #14514