-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fixes #3171: Fall back to Throwable Location strategy on Android #3619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Works around an Android Runtime bug where StackWalker would fail to traverse the stack if a stack frame involves java.lang.Proxy. Disables StackWalker for Android versions that do not yet include the fix in https://r.android.com/3548340. This issue was also reported as linkedin/dexmaker#190. Change-Id: I5b81e552666924302971ee8b84e63865281674dc
943a16f
to
7b9fc32
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3619 +/- ##
============================================
- Coverage 86.46% 86.45% -0.02%
- Complexity 2952 2955 +3
============================================
Files 340 341 +1
Lines 8971 8984 +13
Branches 1103 1103
============================================
+ Hits 7757 7767 +10
- Misses 934 935 +1
- Partials 280 282 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@adrianroos thanks for the PR. Can you fix the CI build? |
As far as I can tell this is a flaky test for verify with a delay, but I can't seem to retry the CI run? |
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [org.mockito:mockito-core](https://github.com/mockito/mockito) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.16.1` -> `5.17.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.15` -> `2.31.16` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.15` -> `2.31.16` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.15` -> `2.31.16` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.15` -> `2.31.16` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.15` -> `2.31.16` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.15` -> `2.31.16` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.15` -> `2.31.16` | --- ### Release Notes <details> <summary>mockito/mockito (org.mockito:mockito-core)</summary> ### [`v5.17.0`](https://github.com/mockito/mockito/releases/tag/v5.17.0) <sup><sup>*Changelog generated by [Shipkit Changelog Gradle Plugin](https://github.com/shipkit/shipkit-changelog)*</sup></sup> ##### 5.17.0 - 2025-04-04 - [7 commit(s)](mockito/mockito@v5.16.1...v5.17.0) by Adrian Roos, Andre Kurait, Jan Ouwens, Rafael Winterhalter, Taeik Lim, Thach Le, Tim van der Lippe - Fixes [#​3631](mockito/mockito#3631): Fix broken banner image link [(#​3632)](mockito/mockito#3632) - Banner image is broken [(#​3631)](mockito/mockito#3631) - Update exception message with mockito-inline [(#​3628)](mockito/mockito#3628) - Clarify structure of commit messages [(#​3626)](mockito/mockito#3626) - Fixes [#​3622](mockito/mockito#3622): MockitoExtension fails cleanup when aborted before setup [(#​3623)](mockito/mockito#3623) - MockitoExtension fails cleanup when aborted before setup [(#​3622)](mockito/mockito#3622) - Since mockito-inline has been removed, the exception messages with `mockito-inline` should be modified. [(#​3621)](mockito/mockito#3621) - Fixes [#​3171](mockito/mockito#3171): Fall back to Throwable Location strategy on Android [(#​3619)](mockito/mockito#3619) - Fixes [#​3615](mockito/mockito#3615) : broken links to javadoc.io [(#​3616)](mockito/mockito#3616) - Broken links to javadoc.io [(#​3615)](mockito/mockito#3615) - Mocks are not working on particular devices after update Android SDK from 33 to 34 [(#​3171)](mockito/mockito#3171) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 610e79d658b797b4e7b64d856b60fcbe8aa64650
Works around an Android Runtime bug where StackWalker would fail to traverse the stack if a stack frame involves java.lang.Proxy.
Disables StackWalker for Android versions that do not yet include the fix in https://r.android.com/3548340.
This issue was also reported as linkedin/dexmaker#190.
Change-Id: I5b81e552666924302971ee8b84e63865281674dc
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>
in the description if relevantFixes #<issue number>
if relevant