Fixed quote escaping issues in PO file formatting #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced string splitting approach with proper character-by-character handling to correctly escape quotes in both normal and raw strings. Improved string formatting with dedicated functions for multiline content and special character escaping. Also simplified the maxArgIndex function. These changes resolve syntax errors in generated PO files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a fix, improvement or something else?
Fix
What does this change implement/fix?
Fixes quote and backslash escaping in PO file generation. The previous implementation couldn't properly handle strings with quotes or special characters, causing syntax errors in the generated files. Replaced string splitting with character-by-character processing to correctly escape all special characters and handle multiline strings properly.
I have ...
It didn't even have its own tests before, in the first place -_-