balancer: disallow producer streams until SubConn has reported READY #7523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
approved these changes
Aug 19, 2024
| defer ss.Stop() | ||
|
|
||
| cc, err := grpc.NewClient("dns:///"+ss.Address, | ||
| grpc.WithDefaultServiceConfig(`{"loadBalancingConfig": [{"`+name+`":{}}]}`), |
There was a problem hiding this comment.
"+name+" : Is this a new fancy way to do fmt.Sprintf?
There was a problem hiding this comment.
it's shorter...? And this is a test so there's no concerns about escaping or buffer overflow attacks or anything, so I think this is OK?
There was a problem hiding this comment.
Sure. I didn't have any concerns about this. I was just curious to understand this new way.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7523 +/- ##
==========================================
- Coverage 82.07% 81.82% -0.26%
==========================================
Files 360 360
Lines 27533 27511 -22
==========================================
- Hits 22599 22512 -87
- Misses 3759 3797 +38
- Partials 1175 1202 +27
|
easwars
approved these changes
Aug 21, 2024
dfawley
added a commit
to dfawley/grpc-go
that referenced
this pull request
Aug 21, 2024
dfawley
added a commit
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the flaky WRR test which is failing due to receiving an ORCA load report before the subconn reports as READY.
RELEASE NOTES: none