-
Notifications
You must be signed in to change notification settings - Fork 76
fix: replace IMarkdownSourceCode
with MarkdownSourceCode
#336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace IMarkdownSourceCode
with MarkdownSourceCode
#336
Conversation
MarkdownRuleDefinition
IMarkdownSourceCode
with MarkdownSourceCode
in MarkdownRuleDefinition
Hi @lumirlumir!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
IMarkdownSourceCode
with MarkdownSourceCode
in MarkdownRuleDefinition
IMarkdownSourceCode
with MarkdownSourceCode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Would like @fasttime to review before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a merge conflict now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that there is a new merge conflict now in src/language/markdown-source-code.js
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending @fasttime's approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Hello,
This PR addresses issue eslint/rewrite#175.
I also added
rollup-plugin-delete
to fix the build issues in CI. It's the same plugin used in JSON'srollup.config.js
.Summary
When using
IMarkdownSourceCode
, we don't have access to methods likegetParent
,getAncestors
,getText
, andlines
. To fix this, I replaced it withMarkdownSourceCode
, which does provide those methods. This approach is already being used in the JSON plugin.Fixes
Fixes: eslint/rewrite#175.