Skip to content

feat: add kendra instance, vpc, permissioning #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Apr 2, 2024

Conversation

MichaelWalker-git
Copy link
Contributor

@MichaelWalker-git MichaelWalker-git commented Mar 4, 2024

Fixes #312


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@MichaelWalker-git MichaelWalker-git marked this pull request as ready for review March 13, 2024 06:09
@MichaelWalker-git MichaelWalker-git requested a review from a team as a code owner March 13, 2024 06:09
@MichaelWalker-git
Copy link
Contributor Author

Screenshot 2024-03-29 at 4 53 11 PM

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 56.36364% with 384 lines in your changes are missing coverage. Please review.

Project coverage is 93.56%. Comparing base (529fbc5) to head (92745c8).

Files Patch % Lines
src/common/helpers/kendra-helper.ts 9.87% 356 Missing ⚠️
src/common/helpers/vpc-helper.ts 88.15% 25 Missing ⚠️
src/common/helpers/utils.ts 94.59% 2 Missing ⚠️
src/common/base-class/base-class.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   96.13%   93.56%   -2.57%     
==========================================
  Files          40       48       +8     
  Lines        9682    10854    +1172     
  Branches      277      319      +42     
==========================================
+ Hits         9308    10156     +848     
- Misses        374      698     +324     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krokoko krokoko self-requested a review April 2, 2024 14:21
krokoko
krokoko previously approved these changes Apr 2, 2024
@krokoko krokoko enabled auto-merge (squash) April 2, 2024 14:23
@krokoko krokoko self-requested a review April 2, 2024 17:46
@krokoko krokoko merged commit a5987ff into main Apr 2, 2024
@krokoko krokoko deleted the feat/kendra_document_ingestion branch April 2, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon Kendra support
5 participants