-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Bump JSII version #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why do we have the |
Because this is how it comes rolling out of the build pipeline. This is in the zip that we get sent via email. I don't know WHY it is, but it is that way right now so I'm just leaving it like that. (What I was telling you is that MASTER is with the |
The official build should have the commit sha in it. Here's the latest one: |
Oh yes, the files are called |
Ok, that's a bug... |
I wonder if we should not use "+" as the separator and instead just use another "-". It seems like it's also common and will avoid issues related to using "+" which is sometimes ignored. Thoughts? |
Honestly, I prefer this as bumping the version means dropping new files in and that's it, no need to mess around with editing hashes in And I think the behavior is on purpose. |
If you want to change the behavior, make a ticket but don't block this change on it please? I'd like to get the package rename out which depends on this. |
Actually you point makes sense... LGTM. Can you just make sure the commit message includes information about what changes in jsii are included here? |
Add service connect default namespace primitive to cdk managed clusters.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.