Skip to content

Bump JSII version #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Bump JSII version #87

merged 1 commit into from
Jun 12, 2018

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jun 12, 2018

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rix0rrr rix0rrr requested review from RomainMuller and eladb June 12, 2018 09:37
@eladb
Copy link
Contributor

eladb commented Jun 12, 2018

Why do we have the -pre postfix on the version?

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Jun 12, 2018

Because this is how it comes rolling out of the build pipeline. This is in the zip that we get sent via email.

I don't know WHY it is, but it is that way right now so I'm just leaving it like that.

(What I was telling you is that MASTER is with the -pre, it was my local version that DIDN'T have it)

@eladb
Copy link
Contributor

eladb commented Jun 12, 2018

The official build should have the commit sha in it. Here's the latest one: jsii-0.4.0-pre+67d5417.zip
Could it be that somehow everything after "+" is omitted when you download the file?

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Jun 12, 2018

Oh yes, the files are called -pre.tgz. The version number INSIDE the package.json still has the hash in it.

@eladb
Copy link
Contributor

eladb commented Jun 12, 2018

Ok, that's a bug...

@eladb
Copy link
Contributor

eladb commented Jun 12, 2018

I wonder if we should not use "+" as the separator and instead just use another "-". It seems like it's also common and will avoid issues related to using "+" which is sometimes ignored. Thoughts?

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Jun 12, 2018

Honestly, I prefer this as bumping the version means dropping new files in and that's it, no need to mess around with editing hashes in package.json too.

And I think the behavior is on purpose.

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Jun 12, 2018

If you want to change the behavior, make a ticket but don't block this change on it please?

I'd like to get the package rename out which depends on this.

@eladb
Copy link
Contributor

eladb commented Jun 12, 2018

Actually you point makes sense... LGTM. Can you just make sure the commit message includes information about what changes in jsii are included here?

@rix0rrr rix0rrr merged commit c004b95 into master Jun 12, 2018
@rix0rrr rix0rrr deleted the huijbers/jsii-bump branch June 12, 2018 09:52
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
homakk added a commit to homakk/aws-cdk that referenced this pull request Dec 1, 2022
Add service connect default namespace primitive to cdk managed clusters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants