Skip to content

feat(custom-resource): update default node runtime to node22 in custom resources for commercial, china and gov regions #34319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 16, 2025

Conversation

godwingrs22
Copy link
Member

@godwingrs22 godwingrs22 commented Apr 30, 2025

Issue # (if applicable)

N/A

Reason for this change

Node 20 is currently in maintenance phase and is slated to reach EOL on 2026-04-30 as indicated on https://nodejs.dev/en/about/releases/.

Description of changes

Update LATEST_NODE_RUNTIME_MAP to Node22 for commerical, china and US Gov regions. This will update CDK to use nodejs22.x' as the runtime for custom resources based on region. The nodejs22.x is not yet available in isolated regions, so it would be still be Node18 for those regions.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Manually tested all individual custom resource handlers for create, update, and delete.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Apr 30, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 30, 2025 21:43
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 30, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@godwingrs22 godwingrs22 marked this pull request as ready for review April 30, 2025 22:30
@godwingrs22 godwingrs22 requested a review from a team as a code owner April 30, 2025 22:30
@godwingrs22 godwingrs22 added the pr/do-not-merge This PR should not be merged at this time. label Apr 30, 2025
@godwingrs22 godwingrs22 added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels May 16, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 16, 2025 19:48

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@godwingrs22 godwingrs22 added pr/do-not-merge This PR should not be merged at this time. and removed pr/do-not-merge This PR should not be merged at this time. labels May 16, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9834cae
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@godwingrs22 godwingrs22 removed the pr/do-not-merge This PR should not be merged at this time. label May 16, 2025
Copy link
Contributor

mergify bot commented May 16, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit eb5e688 into aws:main May 16, 2025
17 of 19 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants