fix(cloudfront): fix validation for unresolved webAclId tokens

[pahud]

Issue # (if applicable)

Closes #34099.

Reason for this change

Fixes a bug where CloudFront Distribution validation would throw a TypeError when webAclId was a CloudFormation token or intrinsic, instead of a plain string. This prevented users from passing unresolved tokens or references as webAclId.

Description of changes

• Updated validateWebAclId() to skip validation if webAclId is not a string or is an unresolved token.
• This prevents .startsWith() from being called on non-string values, avoiding runtime errors.
• Added unit tests to cover unresolved tokens and non-string values.
• Removed the integration test that attempted to deploy dummy WebACL ARNs, which caused CloudFront deployment failures due to invalid account ownership.

This change enables users to safely pass CloudFormation references or tokens as webAclId without causing synthesis errors.

Describe any new or updated permissions being added

None.

Description of how you validated changes

• Added and updated unit tests for validateWebAclId() to cover tokens and non-string values.
• Removed the failing integration test that was not suitable for automated deployment.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (74cbe27) to head (abd4734).
Report is 29 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #34102   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112           

Flag	Coverage Δ
suite.unit	83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	83.98% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: abd4734
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.