aws-s3-deployment: `DeployTimeSubstitutedFile` doesn't keep original file name

[garysassano]

Describe the bug

When using DeployTimeSubstitutedFile, it might seem logical to assume that the uploaded file name, where substitutions are made, remains unchanged. However, this is not the case. Surprisingly, the system utilizes the file's fingerprint as the object key, rather than retaining the original file name. This approach can be quite unintuitive and unhelpful.

Expected Behavior

see above

Current Behavior

see above

Reproduction Steps

see above

Possible Solution

Use the original file name as the object key.

Additional Information/Context

No response

CDK CLI Version

2.115.0

Framework Version

No response

Node.js Version

18.18.2

OS

Windows 11 23H2

Language

TypeScript

Language Version

No response

Other information

No response

[gshpychka]

Seems like a deliberate design choice as opposed to a bug. This would probably make more sense as a feature request.

[khushail]

@garysassano , thanks for reporting this. Agree with @gshpychka , this might be a feature request.

[jmgtan]

Any update on this issue? This is complicating our deployment because we have to do another step to rename the file via S3 API.